[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

--- Comment #4 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Jakub Jelinek from comment #3)
> Created attachment 53494 [details]
> gcc13-pr106721.patch
> 
> Untested fix.  This fixes all <[a-zA-Z] occurrences in tmp-mddump.md (except
> those in comments).  Whether for V*BF or V*HF modes it is better to use i or
> f suffixed broadcast etc. is something I have no idea about, used f for now.

Maybe we should align them with V*HImode like other vector shuffle, broadcast
instructions, which means use i instead?
Others LGTM, thanks for the fix.

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:846e5c009e360f0c4fe58ff0d3aee03ebe3ca1a9

commit r13-2168-g846e5c009e360f0c4fe58ff0d3aee03ebe3ca1a9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Aug 24 09:57:09 2022 +0200

    i386: Fix up mode iterators that weren't expanded [PR106721]

    Currently, when md file reader sees <something> and something is valid mode
    (or code) attribute but which doesn't include case for the current mode
    (or code), it just keeps the <something> untouched.
    I went through all cases matching <[a-zA-Z] in tmp-mddump.md after make
mddump.
    Most of the cases were related to the recent V*BF mode additions, some
    to V*HF mode too, and there was one typo.

    2022-08-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/106721
            * config/i386/sse.md (shuffletype): Add V32BF, V16BF and V8BF
entries.
            Change V32HF, V16HF and V8HF entries from "f" to "i".
            (iptr): Add V32BF, V16BF, V8BF and BF entries.
            (i128vldq): Add V16HF and V16BF entries.
            (avx512er_vmrcp28<mode><mask_name><round_saeonly_name>): Fix typo,
            mask_opernad3 -> mask_operand3.

            * gcc.target/i386/avx512vl-pr106721.c: New test.

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0784ef5e2a7ea72614aa600dccb29e926e46bab6

commit r12-8722-g0784ef5e2a7ea72614aa600dccb29e926e46bab6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Aug 24 09:57:09 2022 +0200

    i386: Fix up mode iterators that weren't expanded [PR106721]

    Currently, when md file reader sees <something> and something is valid mode
    (or code) attribute but which doesn't include case for the current mode
    (or code), it just keeps the <something> untouched.
    I went through all cases matching <[a-zA-Z] in tmp-mddump.md after make
mddump.
    One of the cases was related to the V*HF mode additions and there was one
typo.

    2022-08-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/106721
            * config/i386/sse.md (i128vldq): Add V16HF entry.
            (avx512er_vmrcp28<mode><mask_name><round_saeonly_name>): Fix typo,
            mask_opernad3 -> mask_operand3.

    (cherry picked from commit 846e5c009e360f0c4fe58ff0d3aee03ebe3ca1a9)

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk and for 12.3.

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:edf40e86344c407cadca769a6496905a0ec31e48

commit r11-10358-gedf40e86344c407cadca769a6496905a0ec31e48
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Aug 24 09:57:09 2022 +0200

    i386: Fix up mode iterators that weren't expanded [PR106721]

    Currently, when md file reader sees <something> and something is valid mode
    (or code) attribute but which doesn't include case for the current mode
    (or code), it just keeps the <something> untouched.
    I went through all cases matching <[a-zA-Z] in tmp-mddump.md after make
mddump.
    One of the cases was related to the V*HF mode additions and there was one
typo.

    2022-08-24  Jakub Jelinek  <jakub@redhat.com>

            PR target/106721
            * config/i386/sse.md
            (avx512er_vmrcp28<mode><mask_name><round_saeonly_name>): Fix typo,
            mask_opernad3 -> mask_operand3.

    (cherry picked from commit 846e5c009e360f0c4fe58ff0d3aee03ebe3ca1a9)

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.3
      Known to fail|                            |12.2.0
      Known to work|                            |12.2.1
           Keywords|                            |assemble-failure

[Bug target/106721] Error: invalid character '<' in mnemonic since r13-2122-g86c0d98620ee3a

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106721

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |n.deshmukh at samsung dot com

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 109204 has been marked as a duplicate of this bug. ***