public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/106736] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:333
Date: Sat, 27 Aug 2022 13:43:19 +0000	[thread overview]
Message-ID: <bug-106736-4-4OTgNJ8zJM@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106736-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106736

--- Comment #7 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #5)
> (In reply to Kewen Lin from comment #4)
> > Thanks for the comments! One patch guarding these types is attached, it can
> > fix the ICE.
> 
> That won't work, because that's what we used to do! :-)   In PR96125, the
> test case there is compiled with -mcpu=power8, but uses a pragma/target
> attribute to compile a function with -mcpu=power10/-mmma.  The problem is
> that built-in and target type initialization is only done once, so we can't
> tell from the explicit options being used, whether there will be a function
> later that uses a pragma/target attribute, so we have to assume there will
> be.
> 

aha, good point! Yeah, then the patch is wrong.

> Therefore, we have to always initialize them as we do now, but somehow later
> catch any illegal usage.  Ideas on how to do that welcome! :-)

> ...and we actually do catch the illegal usage, but how we can fail
> gracefully instead of an ICE is what we need to figure out.  Maybe similar
> to your PR103353, we just need the mov[xo]o patterns to succeed temporarily
> so we can fail gracefully later?

Good idea! Btw if changing the current unreachable to FAIL, it will expand as
multiple words without errors, but it's unexpected as we don't want the types
to be used like that. Maybe we can use an "error" for this kind of usage
instead of the current unreachable, will have a further look.

  parent reply	other threads:[~2022-08-27 13:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25  5:55 [Bug target/106736] New: " asolokha at gmx dot com
2022-08-25  5:57 ` [Bug target/106736] " asolokha at gmx dot com
2022-08-25  8:31 ` rguenth at gcc dot gnu.org
2022-08-25  9:21 ` linkw at gcc dot gnu.org
2022-08-25 12:01 ` bergner at gcc dot gnu.org
2022-08-26 11:33 ` linkw at gcc dot gnu.org
2022-08-26 18:51 ` bergner at gcc dot gnu.org
2022-08-26 19:06 ` bergner at gcc dot gnu.org
2022-08-27 13:43 ` linkw at gcc dot gnu.org [this message]
2022-08-31  2:42 ` linkw at gcc dot gnu.org
2022-08-31 18:46 ` segher at gcc dot gnu.org
2022-08-31 19:34 ` bergner at gcc dot gnu.org
2022-08-31 21:00 ` segher at gcc dot gnu.org
2022-09-07  6:51 ` linkw at gcc dot gnu.org
2022-10-19  7:08 ` rguenth at gcc dot gnu.org
2022-12-21  3:07 ` cvs-commit at gcc dot gnu.org
2022-12-27 19:33 ` asolokha at gmx dot com
2023-01-03  2:01 ` linkw at gcc dot gnu.org
2023-01-03  6:56 ` asolokha at gmx dot com
2023-01-03  7:08 ` linkw at gcc dot gnu.org
2023-01-05  5:30 ` cvs-commit at gcc dot gnu.org
2023-01-05  5:32 ` cvs-commit at gcc dot gnu.org
2023-01-05  5:33 ` cvs-commit at gcc dot gnu.org
2023-01-05  5:36 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106736-4-4OTgNJ8zJM@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).