public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/106736] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:333 Date: Thu, 05 Jan 2023 05:30:53 +0000 [thread overview] Message-ID: <bug-106736-4-UwV8BAMOGt@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106736-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106736 --- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>: https://gcc.gnu.org/g:92ee4e1f2792355744bf8740dccf39441b437bcf commit r12-9029-g92ee4e1f2792355744bf8740dccf39441b437bcf Author: Kewen Lin <linkw@linux.ibm.com> Date: Tue Dec 20 21:02:08 2022 -0600 rs6000: Raise error for __vector_{quad,pair} uses without MMA enabled [PR106736] As PR106736 shows, it's unexpected to use __vector_quad and __vector_pair types without MMA support, it would cause ICE when expanding the corresponding assignment. We can't guard these built-in types registering under MMA support as Peter pointed out in that PR, because the registering is global, it doesn't work for target pragma/attribute support with MMA enabled. The existing verify_type_context mentioned in [2] can help to make the diagnostics invalid built-in type uses better, but as Richard pointed out in [4], it can't deal with all cases. As the discussions in [1][3], this patch is to check the invalid use of built-in types __vector_quad and __vector_pair in mov pattern of OOmode and XOmode, on the currently being expanded gimple assignment statement. It still puts an assertion in else arm rather than just makes it go through, it's to ensure we can catch any other possible unexpected cases in time if there are. [1] https://gcc.gnu.org/pipermail/gcc/2022-December/240218.html [2] https://gcc.gnu.org/pipermail/gcc/2022-December/240220.html [3] https://gcc.gnu.org/pipermail/gcc/2022-December/240223.html [4] https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608083.html PR target/106736 gcc/ChangeLog: * config/rs6000/mma.md (define_expand movoo): Call function rs6000_opaque_type_invalid_use_p to check and emit error message for the invalid use of opaque type. (define_expand movxo): Likewise. * config/rs6000/rs6000-protos.h (rs6000_opaque_type_invalid_use_p): New function declaration. (currently_expanding_gimple_stmt): New extern declaration. * config/rs6000/rs6000.cc (rs6000_opaque_type_invalid_use_p): New function. gcc/testsuite/ChangeLog: * gcc.target/powerpc/pr106736-1.c: New test. * gcc.target/powerpc/pr106736-2.c: Likewise. * gcc.target/powerpc/pr106736-3.c: Likewise. * gcc.target/powerpc/pr106736-4.c: Likewise. * gcc.target/powerpc/pr106736-5.c: Likewise.
next prev parent reply other threads:[~2023-01-05 5:30 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-25 5:55 [Bug target/106736] New: " asolokha at gmx dot com 2022-08-25 5:57 ` [Bug target/106736] " asolokha at gmx dot com 2022-08-25 8:31 ` rguenth at gcc dot gnu.org 2022-08-25 9:21 ` linkw at gcc dot gnu.org 2022-08-25 12:01 ` bergner at gcc dot gnu.org 2022-08-26 11:33 ` linkw at gcc dot gnu.org 2022-08-26 18:51 ` bergner at gcc dot gnu.org 2022-08-26 19:06 ` bergner at gcc dot gnu.org 2022-08-27 13:43 ` linkw at gcc dot gnu.org 2022-08-31 2:42 ` linkw at gcc dot gnu.org 2022-08-31 18:46 ` segher at gcc dot gnu.org 2022-08-31 19:34 ` bergner at gcc dot gnu.org 2022-08-31 21:00 ` segher at gcc dot gnu.org 2022-09-07 6:51 ` linkw at gcc dot gnu.org 2022-10-19 7:08 ` rguenth at gcc dot gnu.org 2022-12-21 3:07 ` cvs-commit at gcc dot gnu.org 2022-12-27 19:33 ` asolokha at gmx dot com 2023-01-03 2:01 ` linkw at gcc dot gnu.org 2023-01-03 6:56 ` asolokha at gmx dot com 2023-01-03 7:08 ` linkw at gcc dot gnu.org 2023-01-05 5:30 ` cvs-commit at gcc dot gnu.org [this message] 2023-01-05 5:32 ` cvs-commit at gcc dot gnu.org 2023-01-05 5:33 ` cvs-commit at gcc dot gnu.org 2023-01-05 5:36 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106736-4-UwV8BAMOGt@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).