[Bug libstdc++/106766] New: zip_view::_Iterator/_Sentinel's operator- use make_unsigned_t

[Bug libstdc++/106766] New: zip_view::_Iterator/_Sentinel's operator- use make_unsigned_t

[hewillk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106766

            Bug ID: 106766
           Summary: zip_view::_Iterator/_Sentinel's operator- use
                    make_unsigned_t
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

#include <ranges>

auto r = std::views::zip(
  std::views::iota(__int128(0), __int128(1)));
auto d = r.end() - r.begin();

https://godbolt.org/z/rrK1ve4o7

[Bug libstdc++/106766] zip_view::_Iterator/_Sentinel's operator- use make_unsigned_t

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106766

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-08-29
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |ppalka at gcc dot gnu.org

[Bug libstdc++/106766] zip_view::_Iterator/_Sentinel's operator- use make_unsigned_t

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106766

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:718a6d475b3d17759618c68331c85f55c58ec9a3

commit r13-2567-g718a6d475b3d17759618c68331c85f55c58ec9a3
Author: Patrick Palka <ppalka@redhat.com>
Date:   Fri Sep 9 14:56:32 2022 -0400

    libstdc++: Fix zip_view's operator- for integer-class difference type
[PR106766]

    The difference type of an underlying iterator could be an integer-class
    type, which make_unsigned_t doesn't handle, so we need to use the more
    general __make_unsigned_like_t / __to_unsigned_like here instead.

            PR libstdc++/106766

    libstdc++-v3/ChangeLog:

            * include/std/ranges (zip_view::_Iterator::operator-): Use
            __to_unsigned_like instead of make_unsigned_t.
            (zip_view::_Sentinel::operator-): Likewise.
            * testsuite/std/ranges/zip/1.cc (test04): New test.

[Bug libstdc++/106766] zip_view::_Iterator/_Sentinel's operator- use make_unsigned_t

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106766

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed.