public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/106826] [13 Regression] [modules] Variable template of type trait via importable header gives wrong result
Date: Thu, 22 Sep 2022 12:47:02 +0000	[thread overview]
Message-ID: <bug-106826-4-q7Vbrf83D4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106826-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106826

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:32d8123cd6ce87acb557aec230e8359051316f9f

commit r13-2775-g32d8123cd6ce87acb557aec230e8359051316f9f
Author: Patrick Palka <ppalka@redhat.com>
Date:   Thu Sep 22 08:46:23 2022 -0400

    c++ modules: partial variable template specializations [PR106826]

    With partial variable template specializations, it looks like we
    stream the VAR_DECL (i.e. the DECL_TEMPLATE_RESULT of the corresponding
    TEMPLATE_DECL) since process_partial_specialization adds it to the
    specializations table, but we end up never streaming the corresponding
    TEMPLATE_DECL itself that's reachable only from the primary template's
    DECL_TEMPLATE_SPECIALIZATIONS list, which leads to this list being
    incomplete on stream-in.

    The modules machinery already has special logic for streaming partial
    specializations of class templates; this patch attempts to generalize
    it to handle those of variable templates as well.

            PR c++/106826

    gcc/cp/ChangeLog:

            * module.cc (trees_out::decl_value): Use get_template_info in
            the MK_partial case to handle both VAR_DECL and TYPE_DECL.
            (trees_out::key_mergeable): Likewise.
            (trees_in::key_mergeable): Likewise.
            (has_definition): Consider DECL_INITIAL of a partial variable
            template specialization.
            (depset::hash::make_dependency): Handle partial variable template
            specializations too.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/partial-2_a.C: New test.
            * g++.dg/modules/partial-2_b.C: New test.

  parent reply	other threads:[~2022-09-22 12:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 17:57 [Bug c++/106826] New: " johelegp at gmail dot com
2022-09-05 18:59 ` [Bug c++/106826] [13 Regression] " johelegp at gmail dot com
2022-09-21 12:29 ` ppalka at gcc dot gnu.org
2022-09-22  5:04 ` johelegp at gmail dot com
2022-09-22 12:47 ` cvs-commit at gcc dot gnu.org [this message]
2022-09-22 12:56 ` ppalka at gcc dot gnu.org
2022-09-22 12:57 ` ppalka at gcc dot gnu.org
2022-09-22 14:08 ` johelegp at gmail dot com
2022-09-25 17:14 ` johelegp at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106826-4-q7Vbrf83D4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).