[Bug c/106836] New: [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636

[Bug c/106836] New: [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

            Bug ID: 106836
           Summary: [13 Regression] ICE in c_omp_split_clauses, at
                    c-family/c-omp.cc:2636
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: openmp
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 13.0.0 20220904 snapshot (g:20d30e737ad79dc36817e59f1676aa8bc0c6b325) ICEs
when compiling the following testcase, reduced from
test/OpenMP/target_parallel_depend_messages.cpp (and a bunch of related ones)
from the clang 14.0 test suite, w/ -fopenmp:

void
foo (void)
{
#pragma omp target parallel depend (source)
}

% gcc-13.0.0 -fopenmp -c sf6jpufz.c
sf6jpufz.c: In function 'foo':
sf6jpufz.c:4:9: internal compiler error: in c_omp_split_clauses, at
c-family/c-omp.cc:2636
    4 | #pragma omp target parallel depend (source)
      |         ^~~
0x6859f4 c_omp_split_clauses(unsigned int, tree_code, wide_int_bitmask,
tree_node*, tree_node**)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c-family/c-omp.cc:2636
0x8d2ccf omp_split_clauses
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:19897
0x909d75 c_parser_omp_parallel
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:20589
0x90b2d3 c_parser_omp_target
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:21447
0x90189e c_parser_compound_statement_nostart
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:5798
0x902194 c_parser_compound_statement
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:5640
0x903ea3 c_parser_declaration_or_fndef
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:2554
0x90c273 c_parser_external_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:1789
0x90ccdb c_parser_translation_unit
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:1662
0x90ccdb c_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c/c-parser.cc:23669
0x96f7a1 c_common_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220904/work/gcc-13-20220904/gcc/c-family/c-opts.cc:1255

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |c_omp_split_clauses, at     |c_omp_split_clauses, at
                   |c-family/c-omp.cc:2636      |c-family/c-omp.cc:2636
                   |                            |since
                   |                            |r13-2388-ga651e6d59188da89
   Last reconfirmed|                            |2022-09-05
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-2388-ga651e6d59188da89.

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 53538
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53538&action=edit
gcc13-pr106836.patch

Untested fix.

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793

commit r13-2489-g1bf8b7adc2de6f2ddaffa3af131b6855ae3e3793
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Sep 6 09:21:10 2022 +0200

    openmp: Fix ICE when splitting invalid depend(source)/depend(sink:vec)

    As we now create OMP_CLAUSE_DOACROSS rather than OMP_CLAUSE_DEPEND when
    depend is used with source/sink modifiers, c_omp_split_clauses can see
    OMP_CLAUSE_DOACROSS clause too before we diagnose it as erroneous.

    The following patch treats it like OMP_CLAUSE_DEPEND during
    the splitting but adds an assertion.

    2022-09-06  Jakub Jelinek  <jakub@redhat.com>

            PR c/106836
            * c-omp.cc (c_omp_split_clauses): Handle OMP_CLAUSE_DOACROSS.

            * c-c++-common/gomp/pr106836.c: New test.

[Bug c/106836] [13 Regression] ICE in c_omp_split_clauses, at c-family/c-omp.cc:2636 since r13-2388-ga651e6d59188da89

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106836

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be fixed now.