[Bug c++/106877] New: [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076

[Bug c++/106877] New: [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

            Bug ID: 106877
           Summary: [12/13 Regression] ICE in move_for_stack_reg, at
                    reg-stack.cc:1076
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r12 before 20210502, at -O or -O1,
with file g++.dg/ext/pr84683.C or pr84828.C :


$ g++-13-20220904 -c pr84683.C -O1 -m16 -mtune=sandybridge
-flive-range-shrinkage -fno-dce
pr84683.C: In function 'void foo(float, double)':
pr84683.C:10:7: error: output constraint 0 must specify a single register
   10 |       asm volatile ("" : "+f" (c));     // { dg-error "must specify a
single register" }
      |       ^~~
during RTL pass: stack
pr84683.C:13:1: internal compiler error: in move_for_stack_reg, at
reg-stack.cc:1076
   13 | }
      | ^
0x11163b0 move_for_stack_reg
        ../../gcc/reg-stack.cc:1076
0x1117aca subst_stack_regs
        ../../gcc/reg-stack.cc:2457
0x1117c78 convert_regs_1
        ../../gcc/reg-stack.cc:3091
0x1117c78 convert_regs_2
        ../../gcc/reg-stack.cc:3225
0x1119b88 convert_regs
        ../../gcc/reg-stack.cc:3260
0x1119b88 reg_to_stack
        ../../gcc/reg-stack.cc:3385
0x1119b88 rest_of_handle_stack_regs
        ../../gcc/reg-stack.cc:3441
0x1119b88 execute
        ../../gcc/reg-stack.cc:3473

[Bug target/106877] [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
            Summary|[12/13 Regression] ICE in   |[12/13 Regression] ICE in
                   |move_for_stack_reg, at      |move_for_stack_reg, at
                   |reg-stack.cc:1076           |reg-stack.cc:1076 since
                   |                            |r12-248-gb58dc0b803057c0e
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-09-07

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-248-gb58dc0b803057c0e.

[Bug target/106877] [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #1)
> Started with r12-248-gb58dc0b803057c0e.

Obvious this just exposed the issue ...

[Bug target/106877] [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.3

[Bug target/106877] [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[roger at nextmovesoftware dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

Roger Sayle <roger at nextmovesoftware dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |roger at nextmovesoftware dot com
           Assignee|unassigned at gcc dot gnu.org      |roger at nextmovesoftware dot com

--- Comment #3 from Roger Sayle <roger at nextmovesoftware dot com> ---
Patch proposed
https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601526.html

[Bug target/106877] [12/13 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Roger Sayle <sayle@gcc.gnu.org>:

https://gcc.gnu.org/g:ff85f0afc7d5684378944f88a9bc9b931034788b

commit r13-2653-gff85f0afc7d5684378944f88a9bc9b931034788b
Author: Roger Sayle <roger@nextmovesoftware.com>
Date:   Tue Sep 13 19:49:20 2022 +0100

    PR target/106877: Robustify reg-stack to malformed asm.

    This patch resolves PR target/106877 an ICE-on-invalid inline-asm
    regression.  An innocent upstream change means that the test case
    from PR inline-asm/84683 now hits a different assert in reg-stack.cc's
    move_for_stack_reg.  Fixed by duplicating Jakub's solution to PR 84683
    https://gcc.gnu.org/pipermail/gcc-patches/2018-March/495193.html at
    this second (similar) gcc_assert.

    2022-09-13  Roger Sayle  <roger@nextmovesoftware.com>

    gcc/ChangeLog
            PR target/106877
            * reg-stack.cc (move_for_stack_reg): Check for any_malformed_asm
            in gcc_assert.

    gcc/testsuite/ChangeLog
            PR target/106877
            * g++.dg/ext/pr106877.C: New test case.

[Bug target/106877] [12 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13 Regression] ICE in   |[12 Regression] ICE in
                   |move_for_stack_reg, at      |move_for_stack_reg, at
                   |reg-stack.cc:1076 since     |reg-stack.cc:1076 since
                   |r12-248-gb58dc0b803057c0e   |r12-248-gb58dc0b803057c0e
           Priority|P3                          |P4
      Known to work|                            |13.0

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug target/106877] [12 Regression] ICE in move_for_stack_reg, at reg-stack.cc:1076 since r12-248-gb58dc0b803057c0e

[roger at nextmovesoftware dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106877

Roger Sayle <roger at nextmovesoftware dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.3                        |13.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Roger Sayle <roger at nextmovesoftware dot com> ---
Please let me know if you'd like this backported to the gcc-12 release branch,
but I'm assuming that a low priority ICE-on-invalid means we can now consider
this closed.