[Bug fortran/106911] New: ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[Bug fortran/106911] New: ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

            Bug ID: 106911
           Summary: ICE in gfc_convert_mpz_to_signed, at
                    fortran/simplify.cc:193
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   integer, parameter :: a = 10
   integer, parameter :: b = 20
   interface
      subroutine s
         integer, parameter :: c = ishftc(1_1, a, b)
      end
   end interface
end


$ gfortran-13-20220911 -c z1.f90
f951: internal compiler error: in gfc_convert_mpz_to_signed, at
fortran/simplify.cc:193
0x8846e1 gfc_convert_mpz_to_signed(__mpz_struct*, int)
        ../../gcc/fortran/simplify.cc:193
0x88a75a gfc_simplify_ishftc(gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.cc:4031
0x808f4a do_simplify
        ../../gcc/fortran/intrinsic.cc:4677
0x813dc8 gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:4942
0x7f9c2c gfc_simplify_expr(gfc_expr*, int)
        ../../gcc/fortran/expr.cc:2228
0x813f7e gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:5092
0x869578 resolve_unknown_f
        ../../gcc/fortran/resolve.cc:2990
0x869578 resolve_function
        ../../gcc/fortran/resolve.cc:3347
0x869578 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7194
0x7f8e04 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.cc:3163
0x7fbd90 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.cc:3211
0x7e5d2b variable_decl
        ../../gcc/fortran/decl.cc:3028
0x7e5d2b gfc_match_data_decl()
        ../../gcc/fortran/decl.cc:6331
0x8519c3 match_word
        ../../gcc/fortran/parse.cc:67
0x8519c3 decode_statement
        ../../gcc/fortran/parse.cc:378
0x85340a next_free
        ../../gcc/fortran/parse.cc:1399
0x85340a next_statement
        ../../gcc/fortran/parse.cc:1631
0x8556f4 parse_spec
        ../../gcc/fortran/parse.cc:3986
0x8550ae parse_interface
        ../../gcc/fortran/parse.cc:3849
0x8550ae parse_spec
        ../../gcc/fortran/parse.cc:4123

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---


Errors detected :


$ cat z2.f90
program p
   integer, parameter :: a = 10
   integer, parameter :: b = 20
   integer, parameter :: c = ishftc(1_1, a, b)
end


$ cat z3.f90
program p
   integer, parameter :: a = 10
   integer, parameter :: b = 20
   interface
      subroutine s
         import :: a, b
         integer, parameter :: c = ishftc(1_1, a, b)
      end
   end interface
end

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-09-15
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Confirmed.

Potential fix for the ICE:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index bc178d54891..c7202ec0b9a 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -3955,6 +3955,9 @@ gfc_simplify_ishftc (gfc_expr *e, gfc_expr *s, gfc_expr
*sz)
        return NULL;

       gfc_extract_int (sz, &ssize);
+
+      if (ssize > isize || ssize <= 0)
+       return NULL;
     }
   else
     ssize = isize;

However, this would change the issue to an accepts-invalid.

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from anlauf at gcc dot gnu.org ---
This is better:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index aff9a1b8ced..2c75605ca08 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -3955,6 +3955,9 @@ gfc_simplify_ishftc (gfc_expr *e, gfc_expr *s, gfc_expr
*sz)
        return NULL;

       gfc_extract_int (sz, &ssize);
+
+      if (ssize > isize || ssize <= 0)
+       return &gfc_bad_expr;
     }
   else
     ssize = isize;

Regtested OK.  Taking.

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

--- Comment #4 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-December/058613.html

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:ae4438537fbc2ed04f3b0fb32d4e02b0ed6977a1

commit r13-4595-gae4438537fbc2ed04f3b0fb32d4e02b0ed6977a1
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Dec 10 22:05:15 2022 +0100

    Fortran: reject bad SIZE argument while simplifying ISHFTC [PR106911]

    gcc/fortran/ChangeLog:

            PR fortran/106911
            * simplify.cc (gfc_simplify_ishftc): If the SIZE argument is known
            to be outside the allowed range, terminate simplification.

    gcc/testsuite/ChangeLog:

            PR fortran/106911
            * gfortran.dg/pr106911.f90: New test.

[Bug fortran/106911] ICE in gfc_convert_mpz_to_signed, at fortran/simplify.cc:193

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106911

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |13.0
         Resolution|---                         |FIXED

--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed for gcc-13.  Closing.

Thanks for the report!