[Bug c++/106937] [10/11/12/13 Regression] ICE tree check: expected identifier_node, have tree_list in pp_tree_identifier, at tree-pretty-print.cc:4606 since r10-1214-g1bf32c1141e23074

["cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106937

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:67efffec943656a509e036cd3c785a5c3d6885e1

commit r13-3202-g67efffec943656a509e036cd3c785a5c3d6885e1
Author: Marek Polacek <polacek@redhat.com>
Date:   Thu Sep 29 17:49:32 2022 -0400

    c-family: ICE with [[gnu::nocf_check]] [PR106937]

    When getting the name of an attribute, we ought to use
    get_attribute_name, which handles both [[]] and __attribute__(())
    forms.  Failure to do so may result in an ICE, like here.

    pp_c_attributes_display wasn't able to print the [[]] form of
    attributes, so this patch teaches it to.

    When printing a pointer to function with a standard attribute, the
attribute
    should be printed after the parameter-list.  With this patch we print:

      aka 'void (*)(int) [[gnu::nocf_check]]'

    or, in C++ with noexcept:

      aka 'void (*)(int) noexcept [[gnu::nocf_check]]'

    pp_c_attributes has been unused since its introduction in r56273 so
    this patch removes it.

            PR c++/106937

    gcc/c-family/ChangeLog:

            * c-pretty-print.cc (pp_c_specifier_qualifier_list): Print only GNU
            attributes here.
            (c_pretty_printer::direct_abstract_declarator): Print the standard
[[]]
            attributes here.
            (pp_c_attributes): Remove.
            (pp_c_attributes_display): Print the [[]] form if appropriate.  Use
            get_attribute_name.  Don't print a trailing space when printing the
            [[]] form.
            * c-pretty-print.h (pp_c_attributes): Remove.

    gcc/cp/ChangeLog:

            * error.cc: Include "attribs.h".
            (dump_type_prefix): Print only GNU attributes here.
            (dump_type_suffix): Print standard attributes here.

    gcc/testsuite/ChangeLog:

            * c-c++-common/pointer-to-fn1.c: New test.