[Bug c/106984] New: [13 Regression] ICE with -fsanitize=thread : verify_gimple failed

[Bug c/106984] New: [13 Regression] ICE with -fsanitize=thread : verify_gimple failed

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106984

            Bug ID: 106984
           Summary: [13 Regression] ICE with -fsanitize=thread :
                    verify_gimple failed
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20220522 and 20220529, with file
gcc.target/i386/cmpxchg16b-1.c or gcc.target/cris/sync-xchg-1.c :
(gcc configured with --enable-checking=yes)


$ cat z1.c
int svcsw (int *ptr, int oldval, int newval)
{
  return __sync_val_compare_and_swap (ptr, oldval, newval);
}


$ gcc-13-20220918 -c z1.c -fsanitize=thread
z1.c: In function 'svcsw':
z1.c:1:5: error: invalid operands in ternary operation
    1 | int svcsw (int *ptr, int oldval, int newval)
      |     ^~~~~
_3 = _11 != 0 ? oldval.1_2 : _10;
during GIMPLE pass: tsan0
z1.c:1:5: internal compiler error: verify_gimple failed
0xf285d4 verify_gimple_in_cfg(function*, bool)
        ../../gcc/tree-cfg.cc:5585
0xdc513e execute_function_todo
        ../../gcc/passes.cc:2091
0xdc5bc2 execute_todo
        ../../gcc/passes.cc:2145

[Bug c/106984] [13 Regression] ICE with -fsanitize=thread : verify_gimple failed since r13-707-g68e0063397ba820e

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106984

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ICE with    |[13 Regression] ICE with
                   |-fsanitize=thread :         |-fsanitize=thread :
                   |verify_gimple failed        |verify_gimple failed since
                   |                            |r13-707-g68e0063397ba820e
   Target Milestone|---                         |13.0
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
   Last reconfirmed|                            |2022-09-20

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-707-g68e0063397ba820e.

[Bug sanitizer/106984] [13 Regression] ICE with -fsanitize=thread : verify_gimple failed since r13-707-g68e0063397ba820e

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106984

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug sanitizer/106984] [13 Regression] ICE with -fsanitize=thread : verify_gimple failed since r13-707-g68e0063397ba820e

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106984

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:41b5edaa5c03db36ad45a9cf524881de221a1812

commit r13-2759-g41b5edaa5c03db36ad45a9cf524881de221a1812
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 21 11:30:57 2022 +0200

    tree-optimization/106984 - tsan and COND_EXPR GIMPLE

    The following adjusts a missed spot in TSAN for the RHS COND_EXPR
    GIMPLE IL rework.

            PR tree-optimization/106984
            * tsan.cc (instrument_builtin_call): Build the COND_EXPR condition
in
            a separate statement.

            * gcc.dg/tsan/pr106984.c: New testcase.

[Bug sanitizer/106984] [13 Regression] ICE with -fsanitize=thread : verify_gimple failed since r13-707-g68e0063397ba820e

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106984

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.