[Bug fortran/106985] New: ICE in gfc_simplify

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290
@ 2022-09-20 17:34 gscfq@t-online.de
  2022-09-20 19:09 ` [Bug fortran/106985] " anlauf at gcc dot gnu.org
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: gscfq@t-online.de @ 2022-09-20 17:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

            Bug ID: 106985
           Summary: ICE in gfc_simplify_expr, at fortran/expr.cc:2290
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   integer, parameter :: a(2) = 1
   integer, parameter :: b = a(2) + b
end


$ gfortran-13-20220918 -c z1.f90
f951: internal compiler error: Segmentation fault
0xd8e5df crash_signal
        ../../gcc/toplev.cc:314
0x7b7073 gfc_simplify_expr(gfc_expr*, int)
        ../../gcc/fortran/expr.cc:2290
0x7b6b38 simplify_intrinsic_op
        ../../gcc/fortran/expr.cc:1193
0x7b6b38 gfc_simplify_expr(gfc_expr*, int)
        ../../gcc/fortran/expr.cc:2281
0x827c09 resolve_operator
        ../../gcc/fortran/resolve.cc:4511
0x823f9f gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7187
0x7b61a4 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.cc:3163
0x7b9130 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.cc:3211
0x7a322b variable_decl
        ../../gcc/fortran/decl.cc:3028
0x7a322b gfc_match_data_decl()
        ../../gcc/fortran/decl.cc:6331
0x80e9d3 match_word
        ../../gcc/fortran/parse.cc:67
0x80e9d3 decode_statement
        ../../gcc/fortran/parse.cc:378
0x81041a next_free
        ../../gcc/fortran/parse.cc:1399
0x81041a next_statement
        ../../gcc/fortran/parse.cc:1631
0x8119bb parse_spec
        ../../gcc/fortran/parse.cc:4170
0x814b7c parse_progunit
        ../../gcc/fortran/parse.cc:6212
0x816241 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6757
0x8640bf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
@ 2022-09-20 19:09 ` anlauf at gcc dot gnu.org
  2022-09-20 20:26 ` cvs-commit at gcc dot gnu.org
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-20 19:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-09-20

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

NULL pointer dereference.  Untested fix:

diff --git a/gcc/fortran/expr.cc b/gcc/fortran/expr.cc
index be94c18c836..bedf361c00a 100644
--- a/gcc/fortran/expr.cc
+++ b/gcc/fortran/expr.cc
@@ -2287,7 +2287,8 @@ gfc_simplify_expr (gfc_expr *p, int type)
         initialization expression, or we want a subsection.  */
       if (p->symtree->n.sym->attr.flavor == FL_PARAMETER
          && (gfc_init_expr_flag || p->ref
-             || p->symtree->n.sym->value->expr_type != EXPR_ARRAY))
+             || (p->symtree->n.sym->value
+                 && p->symtree->n.sym->value->expr_type != EXPR_ARRAY)))
        {
          if (!simplify_parameter_variable (p, type))
            return false;

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
  2022-09-20 19:09 ` [Bug fortran/106985] " anlauf at gcc dot gnu.org
@ 2022-09-20 20:26 ` cvs-commit at gcc dot gnu.org
  2022-09-20 20:35 ` anlauf at gcc dot gnu.org
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-20 20:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:8dbb15bc2d019488240c1e69d93121b0347ac092

commit r13-2746-g8dbb15bc2d019488240c1e69d93121b0347ac092
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Sep 20 22:23:43 2022 +0200

    Fortran: NULL pointer dereference in invalid simplification [PR106985]

    gcc/fortran/ChangeLog:

            PR fortran/106985
            * expr.cc (gfc_simplify_expr): Avoid NULL pointer dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/106985
            * gfortran.dg/pr106985.f90: New test.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
  2022-09-20 19:09 ` [Bug fortran/106985] " anlauf at gcc dot gnu.org
  2022-09-20 20:26 ` cvs-commit at gcc dot gnu.org
@ 2022-09-20 20:35 ` anlauf at gcc dot gnu.org
  2022-09-29 18:39 ` cvs-commit at gcc dot gnu.org
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-20 20:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from anlauf at gcc dot gnu.org ---
Fixed on mainline.  Closing.

Thanks for the report!

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
                   ` (2 preceding siblings ...)
  2022-09-20 20:35 ` anlauf at gcc dot gnu.org
@ 2022-09-29 18:39 ` cvs-commit at gcc dot gnu.org
  2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
  2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-29 18:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:2e81790f45c9b7ced4d8c70c3122404854aa5be5

commit r12-8796-g2e81790f45c9b7ced4d8c70c3122404854aa5be5
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Sep 20 22:23:43 2022 +0200

    Fortran: NULL pointer dereference in invalid simplification [PR106985]

    gcc/fortran/ChangeLog:

            PR fortran/106985
            * expr.cc (gfc_simplify_expr): Avoid NULL pointer dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/106985
            * gfortran.dg/pr106985.f90: New test.

    (cherry picked from commit 8dbb15bc2d019488240c1e69d93121b0347ac092)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
                   ` (3 preceding siblings ...)
  2022-09-29 18:39 ` cvs-commit at gcc dot gnu.org
@ 2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
  2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-30 20:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:0a4fff071ff48d699b1af94b88f8878da006c770

commit r11-10282-g0a4fff071ff48d699b1af94b88f8878da006c770
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Sep 20 22:23:43 2022 +0200

    Fortran: NULL pointer dereference in invalid simplification [PR106985]

    gcc/fortran/ChangeLog:

            PR fortran/106985
            * expr.c (gfc_simplify_expr): Avoid NULL pointer dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/106985
            * gfortran.dg/pr106985.f90: New test.

    (cherry picked from commit 8dbb15bc2d019488240c1e69d93121b0347ac092)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/106985] ICE in gfc_simplify_expr, at fortran/expr.cc:2290
  2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
                   ` (4 preceding siblings ...)
  2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
@ 2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-30 20:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106985

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:12cd4a7c465b1a0874f5bc4419bd19d8041a8e2a

commit r10-11011-g12cd4a7c465b1a0874f5bc4419bd19d8041a8e2a
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Tue Sep 20 22:23:43 2022 +0200

    Fortran: NULL pointer dereference in invalid simplification [PR106985]

    gcc/fortran/ChangeLog:

            PR fortran/106985
            * expr.c (gfc_simplify_expr): Avoid NULL pointer dereference.

    gcc/testsuite/ChangeLog:

            PR fortran/106985
            * gfortran.dg/pr106985.f90: New test.

    (cherry picked from commit 8dbb15bc2d019488240c1e69d93121b0347ac092)

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-09-30 20:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 17:34 [Bug fortran/106985] New: ICE in gfc_simplify_expr, at fortran/expr.cc:2290 gscfq@t-online.de
2022-09-20 19:09 ` [Bug fortran/106985] " anlauf at gcc dot gnu.org
2022-09-20 20:26 ` cvs-commit at gcc dot gnu.org
2022-09-20 20:35 ` anlauf at gcc dot gnu.org
2022-09-29 18:39 ` cvs-commit at gcc dot gnu.org
2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org
2022-09-30 20:33 ` cvs-commit at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).