public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd
@ 2022-09-20 23:34 kristerw at gcc dot gnu.org
2022-09-21 8:11 ` [Bug tree-optimization/106990] " marxin at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: kristerw at gcc dot gnu.org @ 2022-09-20 23:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990
Bug ID: 106990
Summary: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: kristerw at gcc dot gnu.org
Target Milestone: ---
When UBSan is used, match.pd disables simplifications that can remove UB. But
two simplifications are missing TYPE_OVERFLOW_SANITIZED checks, making the two
tests below fail to report UB when compiled with -fsanitize=undefined.
/* (~X - ~Y) -> Y - X. */
int main(void)
{
volatile int x = -1956816001;
volatile int y = 1999200512;
return ~x - ~y;
}
/* -x & 1 -> x & 1. */
int main(void)
{
volatile int x = 0x80000000;
return -x & 1;
}
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug tree-optimization/106990] Missing TYPE_OVERFLOW_SANITIZED checks in match.pd 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org @ 2022-09-21 8:11 ` marxin at gcc dot gnu.org 2022-09-21 8:12 ` rguenth at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: marxin at gcc dot gnu.org @ 2022-09-21 8:11 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990 Martin Liška <marxin at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Last reconfirmed| |2022-09-21 Status|UNCONFIRMED |NEW CC| |jakub at gcc dot gnu.org, | |marxin at gcc dot gnu.org, | |rguenth at gcc dot gnu.org Ever confirmed|0 |1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106990] Missing TYPE_OVERFLOW_SANITIZED checks in match.pd 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org 2022-09-21 8:11 ` [Bug tree-optimization/106990] " marxin at gcc dot gnu.org @ 2022-09-21 8:12 ` rguenth at gcc dot gnu.org 2022-10-18 14:26 ` jakub at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: rguenth at gcc dot gnu.org @ 2022-09-21 8:12 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |easyhack --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- Thanks for reporting. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106990] Missing TYPE_OVERFLOW_SANITIZED checks in match.pd 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org 2022-09-21 8:11 ` [Bug tree-optimization/106990] " marxin at gcc dot gnu.org 2022-09-21 8:12 ` rguenth at gcc dot gnu.org @ 2022-10-18 14:26 ` jakub at gcc dot gnu.org 2022-10-19 9:29 ` cvs-commit at gcc dot gnu.org 2022-10-19 9:31 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2022-10-18 14:26 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org --- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 53723 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53723&action=edit gcc13-pr106990.patch Untested fix. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106990] Missing TYPE_OVERFLOW_SANITIZED checks in match.pd 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org ` (2 preceding siblings ...) 2022-10-18 14:26 ` jakub at gcc dot gnu.org @ 2022-10-19 9:29 ` cvs-commit at gcc dot gnu.org 2022-10-19 9:31 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-10-19 9:29 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:07cc4c1da1046f0ffda241d59df796417c122ff5 commit r13-3373-g07cc4c1da1046f0ffda241d59df796417c122ff5 Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Oct 19 11:28:42 2022 +0200 match.pd: Add 2 TYPE_OVERFLOW_SANITIZED checks [PR106990] As requested in the PR, this adds 2 TYPE_OVERFLOW_SANITIZED checks and corresponding testcase. 2022-10-19 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/106990 * match.pd ((~X - ~Y) -> Y - X, -x & 1 -> x & 1): Guard with !TYPE_OVERFLOW_SANITIZED (type). * c-c++-common/ubsan/pr106990.c: New test. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/106990] Missing TYPE_OVERFLOW_SANITIZED checks in match.pd 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org ` (3 preceding siblings ...) 2022-10-19 9:29 ` cvs-commit at gcc dot gnu.org @ 2022-10-19 9:31 ` jakub at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: jakub at gcc dot gnu.org @ 2022-10-19 9:31 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106990 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Fixed for 13+. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-19 9:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-20 23:34 [Bug tree-optimization/106990] New: Missing TYPE_OVERFLOW_SANITIZED checks in match.pd kristerw at gcc dot gnu.org 2022-09-21 8:11 ` [Bug tree-optimization/106990] " marxin at gcc dot gnu.org 2022-09-21 8:12 ` rguenth at gcc dot gnu.org 2022-10-18 14:26 ` jakub at gcc dot gnu.org 2022-10-19 9:29 ` cvs-commit at gcc dot gnu.org 2022-10-19 9:31 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).