[Bug sanitizer/106998] New: libsanitizer PATH_MAX not defined for linux new targets

[Bug sanitizer/106998] New: libsanitizer PATH_MAX not defined for linux new targets

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

            Bug ID: 106998
           Summary: libsanitizer PATH_MAX not defined for linux new
                    targets
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---

../../../../../../../gcc/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:438:23:
error: 'PATH_MAX' was not declared in this scope; did you mean 'PTY_MAX'?
  438 |   unsigned path_max = PATH_MAX;
      |                       ^~~~~~~~
      |                       PTY_MAX

should include <linux/limits.h>

[Bug sanitizer/106998] [10/11/12/13 Regression] libsanitizer PATH_MAX not defined for linux new targets

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5
            Summary|libsanitizer PATH_MAX not   |[10/11/12/13 Regression]
                   |defined for linux new       |libsanitizer PATH_MAX not
                   |targets                     |defined for linux new
                   |                            |targets

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This should be reported upstream but this is a regression due to a pull from
upstream (r9-3752-geac975312214dc )

[Bug sanitizer/106998] [10/11/12/13 Regression] libsanitizer PATH_MAX not defined for linux new targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Is this meanwhile resolved or upstream reported?

[Bug sanitizer/106998] [10/11/12/13 Regression] libsanitizer PATH_MAX not defined for linux new targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I don't see linux/limits.h included still, but limits.h is - should musl
include linux/limits.h by itself?

Please link to upstream generated issues.

[Bug sanitizer/106998] [10/11/12/13 Regression] libsanitizer PATH_MAX not defined for linux new targets

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

--- Comment #4 from cqwrteur <unlvsur at live dot com> ---
(In reply to Richard Biener from comment #3)
> I don't see linux/limits.h included still, but limits.h is - should musl
> include linux/limits.h by itself?
> 
> Please link to upstream generated issues.

musl does not even want you to detect anything. There is not even __musl__
macro

[Bug sanitizer/106998] [10/11/12/13 Regression] libsanitizer PATH_MAX not defined for linux new targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2023-03-27
     Ever confirmed|0                           |1

[Bug sanitizer/106998] [11/12/13/14 Regression] libsanitizer PATH_MAX not defined for linux new targets

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug sanitizer/106998] [11/12/13/14 Regression] libsanitizer PATH_MAX not defined for linux new targets

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106998

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |INVALID

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I looked upstream (both llvm and google/sanitizers) and don't see any bug
filed.
I looked into the musl sources, limits.h has the following line:
e8b8f3c90 (Rich Felker 2011-06-25 15:38:00 -0400  47) #define PATH_MAX 4096

So this bug is invalid because musl's limits.h defines it and has had it
defined since 2011 :).