public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/107028] [13 Regression][OpenACC] ICE in install_var_field, at omp-low.cc:797 Date: Thu, 29 Sep 2022 14:05:08 +0000 [thread overview] Message-ID: <bug-107028-4-LGrF2gx9Ea@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107028-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107028 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Julian Brown <jules@gcc.gnu.org>: https://gcc.gnu.org/g:8ace67ddb97698709a622b2f8ba2718524aa5eeb commit r13-2957-g8ace67ddb97698709a622b2f8ba2718524aa5eeb Author: Julian Brown <julian@codesourcery.com> Date: Tue Sep 27 17:39:59 2022 +0000 OpenACC: whole struct vs. component mappings (PR107028) This patch fixes an ICE when both a complete struct variable and components of that struct are mapped on the same directive for OpenACC, using a modified version of the scheme used for OpenMP in the following patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601558.html A new function has been added to make sure that the mapping kinds of the whole struct and the member access are compatible -- conservatively, so as not to copy more to/from the device than the user expects. This version of the patch uses a different method to detect duplicate clauses for OpenACC in oacc_resolve_clause_dependencies, and removes the now-redundant check in omp_accumulate_sibling_lists. (The latter check would no longer trigger when we map the whole struct on the same directive because the component-mapping clauses are now deleted before the check is executed.) 2022-09-28 Julian Brown <julian@codesourcery.com> gcc/ PR middle-end/107028 * gimplify.cc (omp_check_mapping_compatibility, oacc_resolve_clause_dependencies): New functions. (omp_accumulate_sibling_list): Remove redundant duplicate clause detection for OpenACC. (build_struct_sibling_lists): Skip deleted groups. Don't build sibling list for struct variables that are fully mapped on the same directive for OpenACC. (gimplify_scan_omp_clauses): Call oacc_resolve_clause_dependencies. gcc/testsuite/ PR middle-end/107028 * c-c++-common/goacc/struct-component-kind-1.c: New test. * g++.dg/goacc/pr107028-1.C: New test. * g++.dg/goacc/pr107028-2.C: New test. * gfortran.dg/goacc/mapping-tests-5.f90: New test.
next prev parent reply other threads:[~2022-09-29 14:05 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-24 18:58 [Bug middle-end/107028] New: " burnus at gcc dot gnu.org 2022-09-24 21:35 ` [Bug middle-end/107028] " burnus at gcc dot gnu.org 2022-09-25 5:51 ` burnus at gcc dot gnu.org 2022-09-26 9:20 ` rguenth at gcc dot gnu.org 2022-09-29 14:05 ` cvs-commit at gcc dot gnu.org [this message] 2022-09-29 17:35 ` burnus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107028-4-LGrF2gx9Ea@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).