public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6
@ 2022-09-27 19:29 hjl.tools at gmail dot com
2022-09-28 18:16 ` [Bug target/107061] " cvs-commit at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2022-09-27 19:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061
Bug ID: 107061
Summary: ENCODEKEY128 clobbers xmm4-xmm6
Product: gcc
Version: 12.2.1
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: hjl.tools at gmail dot com
CC: crazylht at gmail dot com, wwwhhhyyy333 at gmail dot com
Target Milestone: ---
Target: i386
The current ENCODEKEY128 clears xmm4-xmm6. But Intel key lock spec has
XMM4 through XMM6 are reserved for future usages and software should not
rely upon them being zeroed.
xmm4-xmm6 should be marked as clobbered, not zeroed for future compatibility.
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug target/107061] ENCODEKEY128 clobbers xmm4-xmm6 2022-09-27 19:29 [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6 hjl.tools at gmail dot com @ 2022-09-28 18:16 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:32 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-09-28 18:16 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061 --- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:db288230db55dc1ff626f46c708b555847013a41 commit r13-2919-gdb288230db55dc1ff626f46c708b555847013a41 Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Sep 27 16:19:11 2022 -0700 i386: Mark XMM4-XMM6 as clobbered by encodekey128/encodekey256 encodekey128 and encodekey256 operations clear XMM4-XMM6. But it is documented that XMM4-XMM6 are reserved for future usages and software should not rely upon them being zeroed. Change encodekey128 and encodekey256 to clobber XMM4-XMM6. gcc/ PR target/107061 * config/i386/predicates.md (encodekey128_operation): Check XMM4-XMM6 as clobbered. (encodekey256_operation): Likewise. * config/i386/sse.md (encodekey128u32): Clobber XMM4-XMM6. (encodekey256u32): Likewise. gcc/testsuite/ PR target/107061 * gcc.target/i386/keylocker-encodekey128.c: Don't check XMM4-XMM6. * gcc.target/i386/keylocker-encodekey256.c: Likewise. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/107061] ENCODEKEY128 clobbers xmm4-xmm6 2022-09-27 19:29 [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6 hjl.tools at gmail dot com 2022-09-28 18:16 ` [Bug target/107061] " cvs-commit at gcc dot gnu.org @ 2022-09-29 18:32 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:57 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:58 ` hjl.tools at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-09-29 18:32 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:f1454a75c9a165c0ba30833f23f799044fd7a7fe commit r12-8795-gf1454a75c9a165c0ba30833f23f799044fd7a7fe Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Sep 27 16:19:11 2022 -0700 i386: Mark XMM4-XMM6 as clobbered by encodekey128/encodekey256 encodekey128 and encodekey256 operations clear XMM4-XMM6. But it is documented that XMM4-XMM6 are reserved for future usages and software should not rely upon them being zeroed. Change encodekey128 and encodekey256 to clobber XMM4-XMM6. gcc/ PR target/107061 * config/i386/predicates.md (encodekey128_operation): Check XMM4-XMM6 as clobbered. (encodekey256_operation): Likewise. * config/i386/sse.md (encodekey128u32): Clobber XMM4-XMM6. (encodekey256u32): Likewise. gcc/testsuite/ PR target/107061 * gcc.target/i386/keylocker-encodekey128.c: Don't check XMM4-XMM6. * gcc.target/i386/keylocker-encodekey256.c: Likewise. (cherry picked from commit db288230db55dc1ff626f46c708b555847013a41) ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/107061] ENCODEKEY128 clobbers xmm4-xmm6 2022-09-27 19:29 [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6 hjl.tools at gmail dot com 2022-09-28 18:16 ` [Bug target/107061] " cvs-commit at gcc dot gnu.org 2022-09-29 18:32 ` cvs-commit at gcc dot gnu.org @ 2022-09-29 18:57 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:58 ` hjl.tools at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-09-29 18:57 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-11 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:f8204b10e6bae0721ab74ad77a80b3761ebaf501 commit r11-10279-gf8204b10e6bae0721ab74ad77a80b3761ebaf501 Author: H.J. Lu <hjl.tools@gmail.com> Date: Tue Sep 27 16:19:11 2022 -0700 i386: Mark XMM4-XMM6 as clobbered by encodekey128/encodekey256 encodekey128 and encodekey256 operations clear XMM4-XMM6. But it is documented that XMM4-XMM6 are reserved for future usages and software should not rely upon them being zeroed. Change encodekey128 and encodekey256 to clobber XMM4-XMM6. gcc/ PR target/107061 * config/i386/predicates.md (encodekey128_operation): Check XMM4-XMM6 as clobbered. (encodekey256_operation): Likewise. * config/i386/sse.md (encodekey128u32): Clobber XMM4-XMM6. (encodekey256u32): Likewise. gcc/testsuite/ PR target/107061 * gcc.target/i386/keylocker-encodekey128.c: Don't check XMM4-XMM6. * gcc.target/i386/keylocker-encodekey256.c: Likewise. (cherry picked from commit db288230db55dc1ff626f46c708b555847013a41) ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/107061] ENCODEKEY128 clobbers xmm4-xmm6 2022-09-27 19:29 [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6 hjl.tools at gmail dot com ` (2 preceding siblings ...) 2022-09-29 18:57 ` cvs-commit at gcc dot gnu.org @ 2022-09-29 18:58 ` hjl.tools at gmail dot com 3 siblings, 0 replies; 5+ messages in thread From: hjl.tools at gmail dot com @ 2022-09-29 18:58 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107061 H.J. Lu <hjl.tools at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Target Milestone|--- |11.4 Resolution|--- |FIXED --- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> --- Fixed for GCC 11.4, 12.3 and 13. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-29 18:58 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-09-27 19:29 [Bug target/107061] New: ENCODEKEY128 clobbers xmm4-xmm6 hjl.tools at gmail dot com 2022-09-28 18:16 ` [Bug target/107061] " cvs-commit at gcc dot gnu.org 2022-09-29 18:32 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:57 ` cvs-commit at gcc dot gnu.org 2022-09-29 18:58 ` hjl.tools at gmail dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).