public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rsandifo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/107088] [13 Regression] cselib ICE building __trunctfxf2 on ia64
Date: Fri, 30 Sep 2022 11:49:53 +0000 [thread overview]
Message-ID: <bug-107088-4-k1OgARVj61@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107088-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107088
--- Comment #8 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> ---
(In reply to Stefan Schulze Frielinghaus from comment #6)
> I did a quick test using
>
> diff --git a/gcc/cselib.cc b/gcc/cselib.cc
> index 9b582e5d3d6..2fd0190bc79 100644
> --- a/gcc/cselib.cc
> +++ b/gcc/cselib.cc
> @@ -1571,6 +1571,7 @@ new_cselib_val (unsigned int hash, machine_mode mode,
> rtx x)
>
> scalar_int_mode int_mode;
> if (REG_P (x) && is_int_mode (mode, &int_mode)
> + && int_mode != BImode
> && REG_VALUES (REGNO (x)) != NULL
> && (!cselib_current_insn || !DEBUG_INSN_P (cselib_current_insn)))
> {
>
> which solved the cross ia64 build for me. Maybe there are further integer
> modes which I didn't consider, i.e., I will have a thorough look at it next
> week.
Looks good, but maybe:
GET_MODE_SIZE (int_mode) > 1
would be more general.
BImode being MODE_INT is a horrible wart (it should be MODE_PARTIAL_INT
instead). But unfortunately ia64 is the target that would be most
affected by "fixing" this, and it's not an easy target to test.
So I think in practice nothing will change while ia64 is the in tree.
next prev parent reply other threads:[~2022-09-30 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 17:37 [Bug middle-end/107088] New: " jsm28 at gcc dot gnu.org
2022-09-29 18:33 ` [Bug middle-end/107088] " stefansf at linux dot ibm.com
2022-09-29 18:59 ` rguenth at gcc dot gnu.org
2022-09-29 19:13 ` rguenth at gcc dot gnu.org
2022-09-29 19:14 ` rguenth at gcc dot gnu.org
2022-09-30 8:07 ` stefansf at linux dot ibm.com
2022-09-30 11:22 ` stefansf at linux dot ibm.com
2022-09-30 11:43 ` ams at gcc dot gnu.org
2022-09-30 11:49 ` rsandifo at gcc dot gnu.org [this message]
2022-09-30 11:56 ` ams at gcc dot gnu.org
2022-10-04 11:38 ` stefansf at linux dot ibm.com
2022-10-06 6:47 ` cvs-commit at gcc dot gnu.org
2022-10-06 7:38 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107088-4-k1OgARVj61@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).