public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/107093] AVX512 mask operations not simplified in fully masked loop
Date: Tue, 11 Oct 2022 10:51:06 +0000 [thread overview]
Message-ID: <bug-107093-4-yqpcGJ1uOp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107093-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107093
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Hongtao.liu from comment #4)
> change "*k, CBC" to "?k, CBC", in *mov{qi,hi,si,di}_internal.
> then RA works good to choose kxnor for setting constm1_rtx to mask register,
> and i got below with your attached patch(change #if 0 to #if 1), seems
> better than orginal patch.
>
> 6foo:
> 7.LFB0:
> 8 .cfi_startproc
> 9 testl %edi, %edi
> 10 jle .L9
> 11 kxnorb %k1, %k1, %k1
> 12 cmpl $4, %edi
> 13 jl .L11
> 14.L3:
> 15 vbroadcastsd .LC2(%rip), %ymm3
> 16 vmovdqa .LC0(%rip), %xmm2
> 17 xorl %eax, %eax
> 18 xorl %ecx, %ecx
> 19 .p2align 4,,10
> 20 .p2align 3
> 21.L7:
> 22 vmovapd b(%rax), %ymm0{%k1}
> 23 addl $4, %ecx
> 24 movl %edi, %edx
> 25 vmulpd %ymm3, %ymm0, %ymm1
> 26 subl %ecx, %edx
> 27 cmpl $4, %edx
> 28 vmovapd %ymm1, a(%rax){%k1}
> 29 vpbroadcastd %edx, %xmm1
> 30 movl $-1, %edx
> 31 vpcmpd $1, %xmm1, %xmm2, %k1
> 32 kmovb %k1, %esi
> 33 cmovge %edx, %esi
not sure if the round-trip to GPRs for the sake
of a cmovge is worth, I guess a branch would be
better.
next prev parent reply other threads:[~2022-10-11 10:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 9:06 [Bug target/107093] New: " rguenth at gcc dot gnu.org
2022-09-30 9:09 ` [Bug target/107093] " rguenth at gcc dot gnu.org
2022-10-10 1:50 ` crazylht at gmail dot com
2022-10-11 9:23 ` cvs-commit at gcc dot gnu.org
2022-10-11 10:05 ` crazylht at gmail dot com
2022-10-11 10:13 ` crazylht at gmail dot com
2022-10-11 10:51 ` rguenth at gcc dot gnu.org [this message]
2022-10-11 10:59 ` rguenth at gcc dot gnu.org
2022-10-11 11:08 ` crazylht at gmail dot com
2022-10-11 11:14 ` rguenther at suse dot de
2023-07-24 8:21 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-107093-4-yqpcGJ1uOp@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).