* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
@ 2022-10-03 11:41 ` marxin at gcc dot gnu.org
2022-10-03 11:46 ` zsojka at seznam dot cz
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 11:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-10-03
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
Summary|[13 Regression] wrong code |[13 Regression] wrong code
|with -Os -fno-tree-ccp |with -Os -fno-tree-ccp
|-fno-tree-forwprop |-fno-tree-forwprop
|-fno-tree-fre |-fno-tree-fre since
| |r13-2900-g001c60ccfeaf9a48
CC| |aldyh at gcc dot gnu.org,
| |marxin at gcc dot gnu.org
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-2900-g001c60ccfeaf9a48.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
2022-10-03 11:41 ` [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48 marxin at gcc dot gnu.org
@ 2022-10-03 11:46 ` zsojka at seznam dot cz
2022-10-03 12:02 ` marxin at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: zsojka at seznam dot cz @ 2022-10-03 11:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
--- Comment #2 from Zdenek Sojka <zsojka at seznam dot cz> ---
(In reply to Martin Liška from comment #1)
> Started with r13-2900-g001c60ccfeaf9a48.
Nice, so ffs() with a propagated constant argument now does a popcount()
instead?
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
2022-10-03 11:41 ` [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48 marxin at gcc dot gnu.org
2022-10-03 11:46 ` zsojka at seznam dot cz
@ 2022-10-03 12:02 ` marxin at gcc dot gnu.org
2022-10-03 12:04 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 12:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
> Nice, so ffs() with a propagated constant argument now does a popcount()
> instead?
It should not. The problem is op_cfn_popcount is shared by both popcount and
ffs, but the newly added transformation is valid only for popcount.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
` (2 preceding siblings ...)
2022-10-03 12:02 ` marxin at gcc dot gnu.org
@ 2022-10-03 12:04 ` marxin at gcc dot gnu.org
2022-10-03 15:39 ` aldyh at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-03 12:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
Priority|P3 |P1
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
` (3 preceding siblings ...)
2022-10-03 12:04 ` marxin at gcc dot gnu.org
@ 2022-10-03 15:39 ` aldyh at gcc dot gnu.org
2022-10-03 15:40 ` aldyh at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-10-03 15:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |aldyh at gcc dot gnu.org
--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #3)
> > Nice, so ffs() with a propagated constant argument now does a popcount()
> > instead?
>
> It should not. The problem is op_cfn_popcount is shared by both popcount and
> ffs, but the newly added transformation is valid only for popcount.
Ughh, indeed. Thanks for the analysis Martin.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
` (4 preceding siblings ...)
2022-10-03 15:39 ` aldyh at gcc dot gnu.org
@ 2022-10-03 15:40 ` aldyh at gcc dot gnu.org
2022-10-04 4:28 ` cvs-commit at gcc dot gnu.org
2022-10-04 4:52 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-10-03 15:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 53656
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53656&action=edit
untested patch
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
` (5 preceding siblings ...)
2022-10-03 15:40 ` aldyh at gcc dot gnu.org
@ 2022-10-04 4:28 ` cvs-commit at gcc dot gnu.org
2022-10-04 4:52 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-10-04 4:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:
https://gcc.gnu.org/g:f50d103183c551c7f9f9f20efaf2ebbf83d5e99f
commit r13-3052-gf50d103183c551c7f9f9f20efaf2ebbf83d5e99f
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Mon Oct 3 17:31:32 2022 +0200
[PR107130] range-ops: Separate out ffs and popcount optimizations.
__builtin_popcount and __builtin_ffs were sharing the same range-ops
entry, but the nonzero mask optimization is not valid for ffs.
Separate them out into two entries.
PR tree-optimization/107130
gcc/ChangeLog:
* gimple-range-op.cc (class cfn_popcount): Call op_cfn_ffs.
(class cfn_ffs): New.
(gimple_range_op_handler::maybe_builtin_call): Separate out
CASE_CFN_FFS into its own case.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/pr107130.c: New test.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug tree-optimization/107130] [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre since r13-2900-g001c60ccfeaf9a48
2022-10-03 11:26 [Bug tree-optimization/107130] New: [13 Regression] wrong code with -Os -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre zsojka at seznam dot cz
` (6 preceding siblings ...)
2022-10-04 4:28 ` cvs-commit at gcc dot gnu.org
@ 2022-10-04 4:52 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: aldyh at gcc dot gnu.org @ 2022-10-04 4:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107130
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
fixed
^ permalink raw reply [flat|nested] 9+ messages in thread