[Bug plugins/107136] New: File cp-trait.def not found in kernel build

[Bug plugins/107136] New: File cp-trait.def not found in kernel build

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

            Bug ID: 107136
           Summary: File cp-trait.def not found in kernel build
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I've just been having a go at compiling the new linux-6.0 kernel
with a recent trunk gcc. I get

/home/dcb/gcc/results.20221003/lib/gcc/x86_64-pc-linux-gnu/13.0.0/plugin/include/c-family/c-common.h:172:10:
fatal error: cp/cp-trait.def: No such file or directory

but

$ find /home/dcb/gcc/results.20221003 -name cp-trait.def -print
$

so it looks like that file isn't installed. But

[/home/dcb/gcc/trunk.git] $ find . -name cp-trait\* -print
./gcc/cp/cp-trait.def
[/home/dcb/gcc/trunk.git] $ 

so the file does exist in trunk.

[Bug plugins/107136] File cp-trait.def not found in kernel build

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ppalka at gcc dot gnu.org

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Adding author of the source code file for their best advice.

[Bug plugins/107136] File cp-trait.def not found in kernel build

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|12.0                        |13.0

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I wish plugins API would finally be stable or rather Linux not use Plugins.

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
          Component|plugins                     |c++
           Keywords|                            |plugin

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is most likely the fix but I don't have time to test it right now"
diff --git a/gcc/cp/Make-lang.in b/gcc/cp/Make-lang.in
index 38d8eeed1f0..aa84d6827be 100644
--- a/gcc/cp/Make-lang.in
+++ b/gcc/cp/Make-lang.in
@@ -39,7 +39,7 @@ CXX_INSTALL_NAME := $(shell echo c++|sed
'$(program_transform_name)')
 GXX_INSTALL_NAME := $(shell echo g++|sed '$(program_transform_name)')
 CXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo c++|sed
'$(program_transform_name)')
 GXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo g++|sed
'$(program_transform_name)')
-CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h
operators.def
+CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h
operators.def cp-trait.def

 #^L
 # Define the names for selecting c++ in LANGUAGES.

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

--- Comment #4 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Andrew Pinski from comment #3)
> This is most likely the fix but I don't have time to test it right now"

The obvious copy seems to fix the problem:

[/home/dcb/gcc/trunk.git] $ cp ./gcc/cp/cp-trait.def
../results.20221003/lib/gcc/x86_64-pc-linux-gnu/13.0.0/plugin/include/cp/
[/home/dcb/gcc/trunk.git] $

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Sorry for the breakage!

(In reply to Andrew Pinski from comment #3)
> This is most likely the fix but I don't have time to test it right now"
> diff --git a/gcc/cp/Make-lang.in b/gcc/cp/Make-lang.in
> index 38d8eeed1f0..aa84d6827be 100644
> --- a/gcc/cp/Make-lang.in
> +++ b/gcc/cp/Make-lang.in
> @@ -39,7 +39,7 @@ CXX_INSTALL_NAME := $(shell echo c++|sed
> '$(program_transform_name)')
>  GXX_INSTALL_NAME := $(shell echo g++|sed '$(program_transform_name)')
>  CXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo c++|sed
> '$(program_transform_name)')
>  GXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo g++|sed
> '$(program_transform_name)')
> -CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h
> type-utils.h operators.def
> +CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h
> type-utils.h operators.def cp-trait.def
> 
>  #^L
>  # Define the names for selecting c++ in LANGUAGES.

Makes sense... Looks like a similar fix, r8-4412-g5666f12bbaee55, was needed
for operators.def after r8-4257-gd6dd9d7f8efcf9 made us include it from
cp-tree.h.

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |ppalka at gcc dot gnu.org
   Last reconfirmed|                            |2022-10-04

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

--- Comment #6 from Patrick Palka <ppalka at gcc dot gnu.org> ---
patch posted at
https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602758.html

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:e87879a9f5c2869de177c4dde2172f277e81ef1a

commit r13-3065-ge87879a9f5c2869de177c4dde2172f277e81ef1a
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Oct 4 12:23:46 2022 -0400

    c++: install cp-trait.def as part of plugin headers [PR107136]

    This is apparently needed since we include cp-trait.def from cp-tree.h
    (in order to define the cp_trait_kind enum), as with operators.def.

            PR c++/107136

    gcc/cp/ChangeLog:

            * Make-lang.in (CP_PLUGIN_HEADERS): Add cp-trait.def.

[Bug c++/107136] [13 Regression] File cp/cp-trait.def file not installed for plugin suport

[ppalka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107136

Patrick Palka <ppalka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed