public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/107172] [13 Regression] wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu since r13-1268-g8c99e307b20c502e
Date: Thu, 13 Oct 2022 16:54:47 +0000	[thread overview]
Message-ID: <bug-107172-4-0rlKyIwaH8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107172-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107172

--- Comment #26 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Uroš Bizjak from comment #24)
> (In reply to Hongtao.liu from comment #23)
> > looking at i386.c put_condition_code used by *setcc_qi, it looks like (EQ
> > (reg:CCCmode FLAG_REG) (const_int 0)) means get carry flag.
> > Not (LTU: (REG:CCCmode FLAGS_REG) (const_int 0)).
> > Now I got more confused.
> 
> CCCmode means that single flag is tested, it uses EQ and NE, so "c" and "nc"
> suffix is emitted. When CCmode is used, LTU/GEU operation on CCmode flags
> reg produces "b" and "nb" suffix, which decodes to exactly the same assembly
> as "c" and "nc" suffixes.
> 
> However, it looks that somewhere LTU/GEU is also generated with CCCmode
> flags reg, and some fixup was introduced to put_condition_code to "fix" this
> inconsistency. If LTU/GEU is valid only for CCmode, then the producers of
> invalid RTX should be fixed.

EQ and NE are only used to set FLAGS_REG in CCCmode from 2 integer operands.
LTU/GEU are only used to check FLAGS_REG against constant 0.  This is very
consistent.  simplify_const_relational_operation has

 /* We can't simplify MODE_CC values since we don't know what the
     actual comparison is.  */
  if (GET_MODE_CLASS (GET_MODE (op0)) == MODE_CC)
    return 0;

In case of the comparison in CCCmode with constant op0 and op1, it should
let the backend perform the actual comparison.

  parent reply	other threads:[~2022-10-13 16:54 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 17:51 [Bug tree-optimization/107172] New: wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu zhendong.su at inf dot ethz.ch
2022-10-06 18:02 ` [Bug tree-optimization/107172] [13 Regression] " pinskia at gcc dot gnu.org
2022-10-06 18:46 ` [Bug tree-optimization/107172] [13 Regression] wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu since r13-1268-g8c99e307b20c502e marxin at gcc dot gnu.org
2022-10-07  7:21 ` rguenth at gcc dot gnu.org
2022-10-07 12:17 ` aldyh at gcc dot gnu.org
2022-10-07 21:04 ` [Bug target/107172] " hjl.tools at gmail dot com
2022-10-07 22:20 ` hjl.tools at gmail dot com
2022-10-09 21:51 ` roger at nextmovesoftware dot com
2022-10-10 18:32 ` segher at gcc dot gnu.org
2022-10-10 18:34 ` segher at gcc dot gnu.org
2022-10-10 19:16 ` hjl.tools at gmail dot com
2022-10-10 20:55 ` segher at gcc dot gnu.org
2022-10-11  0:10 ` hjl.tools at gmail dot com
2022-10-11 16:16 ` segher at gcc dot gnu.org
2022-10-11 17:16 ` hjl.tools at gmail dot com
2022-10-11 18:05 ` segher at gcc dot gnu.org
2022-10-11 19:49 ` roger at nextmovesoftware dot com
2022-10-11 20:26 ` segher at gcc dot gnu.org
2022-10-11 22:30 ` hjl.tools at gmail dot com
2022-10-11 22:38 ` hjl.tools at gmail dot com
2022-10-12  7:17 ` crazylht at gmail dot com
2022-10-12  7:25 ` crazylht at gmail dot com
2022-10-12  8:11 ` segher at gcc dot gnu.org
2022-10-12 17:50 ` hjl.tools at gmail dot com
2022-10-13  3:38 ` crazylht at gmail dot com
2022-10-13  8:14 ` ubizjak at gmail dot com
2022-10-13 12:31 ` crazylht at gmail dot com
2022-10-13 16:54 ` hjl.tools at gmail dot com [this message]
2022-10-13 17:49 ` hjl.tools at gmail dot com
2022-10-13 22:07 ` segher at gcc dot gnu.org
2022-10-13 22:12 ` segher at gcc dot gnu.org
2022-10-13 22:20 ` segher at gcc dot gnu.org
2022-10-13 22:23 ` hjl.tools at gmail dot com
2022-10-13 22:34 ` hjl.tools at gmail dot com
2022-10-15 14:53 ` segher at gcc dot gnu.org
2022-10-17  3:28 ` crazylht at gmail dot com
2022-10-17  7:48 ` rguenth at gcc dot gnu.org
2022-10-17  7:55 ` rguenth at gcc dot gnu.org
2022-10-17 15:59 ` hjl.tools at gmail dot com
2022-10-17 22:01 ` segher at gcc dot gnu.org
2022-10-18  0:19 ` hjl.tools at gmail dot com
2022-10-18 14:44 ` segher at gcc dot gnu.org
2022-10-18 19:54 ` hjl.tools at gmail dot com
2022-10-18 20:14 ` segher at gcc dot gnu.org
2022-10-20 17:25 ` pinskia at gcc dot gnu.org
2022-10-20 19:03 ` hjl.tools at gmail dot com
2022-10-22 21:14 ` segher at gcc dot gnu.org
2022-10-27 18:42 ` cvs-commit at gcc dot gnu.org
2022-10-28  9:11 ` roger at nextmovesoftware dot com
2022-10-28 15:48 ` hjl.tools at gmail dot com
2022-11-30 17:33 ` jakub at gcc dot gnu.org
2022-11-30 21:52 ` hjl.tools at gmail dot com
2023-05-30 13:44 ` cvs-commit at gcc dot gnu.org
2023-07-27 14:47 ` shaohua.li at inf dot ethz.ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107172-4-0rlKyIwaH8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).