public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/107172] [13 Regression] wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu since r13-1268-g8c99e307b20c502e Date: Thu, 27 Oct 2022 18:42:48 +0000 [thread overview] Message-ID: <bug-107172-4-FKjsXFEeoS@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107172-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107172 --- Comment #46 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>: https://gcc.gnu.org/g:0e36a9c6915c713d30016cbade97a4b31dcc1350 commit r13-3530-g0e36a9c6915c713d30016cbade97a4b31dcc1350 Author: H.J. Lu <hjl.tools@gmail.com> Date: Thu Oct 20 11:55:19 2022 -0700 x86: Replace ne:CCC/ne:CCO with UNSPEC_CC_NE in neg patterns In i386.md, neg patterns which set MODE_CC register like (set (reg:CCC FLAGS_REG) (ne:CCC (match_operand:SWI48 1 "general_reg_operand") (const_int 0))) can lead to errors when operand 1 is a constant value. If FLAGS_REG in (set (reg:CCC FLAGS_REG) (ne:CCC (const_int 2) (const_int 0))) is set to 1, RTX simplifiers may simplify (set (reg:SI 93) (neg:SI (ltu:SI (reg:CCC 17 flags) (const_int 0 [0])))) as (set (reg:SI 93) (neg:SI (ltu:SI (const_int 1) (const_int 0 [0])))) which leads to incorrect results since LTU on MODE_CC register isn't the same as "unsigned less than" in x86 backend. To prevent RTL optimizers from setting MODE_CC register to a constant, use UNSPEC_CC_NE to replace ne:CCC/ne:CCO when setting FLAGS_REG in neg patterns. gcc/ PR target/107172 * config/i386/i386.md (UNSPEC_CC_NE): New. Replace ne:CCC/ne:CCO with UNSPEC_CC_NE in neg patterns. gcc/testsuite/ PR target/107172 * gcc.target/i386/pr107172.c: New test.
next prev parent reply other threads:[~2022-10-27 18:42 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-06 17:51 [Bug tree-optimization/107172] New: wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu zhendong.su at inf dot ethz.ch 2022-10-06 18:02 ` [Bug tree-optimization/107172] [13 Regression] " pinskia at gcc dot gnu.org 2022-10-06 18:46 ` [Bug tree-optimization/107172] [13 Regression] wrong code with "-O1 -ftree-vrp" on x86_64-linux-gnu since r13-1268-g8c99e307b20c502e marxin at gcc dot gnu.org 2022-10-07 7:21 ` rguenth at gcc dot gnu.org 2022-10-07 12:17 ` aldyh at gcc dot gnu.org 2022-10-07 21:04 ` [Bug target/107172] " hjl.tools at gmail dot com 2022-10-07 22:20 ` hjl.tools at gmail dot com 2022-10-09 21:51 ` roger at nextmovesoftware dot com 2022-10-10 18:32 ` segher at gcc dot gnu.org 2022-10-10 18:34 ` segher at gcc dot gnu.org 2022-10-10 19:16 ` hjl.tools at gmail dot com 2022-10-10 20:55 ` segher at gcc dot gnu.org 2022-10-11 0:10 ` hjl.tools at gmail dot com 2022-10-11 16:16 ` segher at gcc dot gnu.org 2022-10-11 17:16 ` hjl.tools at gmail dot com 2022-10-11 18:05 ` segher at gcc dot gnu.org 2022-10-11 19:49 ` roger at nextmovesoftware dot com 2022-10-11 20:26 ` segher at gcc dot gnu.org 2022-10-11 22:30 ` hjl.tools at gmail dot com 2022-10-11 22:38 ` hjl.tools at gmail dot com 2022-10-12 7:17 ` crazylht at gmail dot com 2022-10-12 7:25 ` crazylht at gmail dot com 2022-10-12 8:11 ` segher at gcc dot gnu.org 2022-10-12 17:50 ` hjl.tools at gmail dot com 2022-10-13 3:38 ` crazylht at gmail dot com 2022-10-13 8:14 ` ubizjak at gmail dot com 2022-10-13 12:31 ` crazylht at gmail dot com 2022-10-13 16:54 ` hjl.tools at gmail dot com 2022-10-13 17:49 ` hjl.tools at gmail dot com 2022-10-13 22:07 ` segher at gcc dot gnu.org 2022-10-13 22:12 ` segher at gcc dot gnu.org 2022-10-13 22:20 ` segher at gcc dot gnu.org 2022-10-13 22:23 ` hjl.tools at gmail dot com 2022-10-13 22:34 ` hjl.tools at gmail dot com 2022-10-15 14:53 ` segher at gcc dot gnu.org 2022-10-17 3:28 ` crazylht at gmail dot com 2022-10-17 7:48 ` rguenth at gcc dot gnu.org 2022-10-17 7:55 ` rguenth at gcc dot gnu.org 2022-10-17 15:59 ` hjl.tools at gmail dot com 2022-10-17 22:01 ` segher at gcc dot gnu.org 2022-10-18 0:19 ` hjl.tools at gmail dot com 2022-10-18 14:44 ` segher at gcc dot gnu.org 2022-10-18 19:54 ` hjl.tools at gmail dot com 2022-10-18 20:14 ` segher at gcc dot gnu.org 2022-10-20 17:25 ` pinskia at gcc dot gnu.org 2022-10-20 19:03 ` hjl.tools at gmail dot com 2022-10-22 21:14 ` segher at gcc dot gnu.org 2022-10-27 18:42 ` cvs-commit at gcc dot gnu.org [this message] 2022-10-28 9:11 ` roger at nextmovesoftware dot com 2022-10-28 15:48 ` hjl.tools at gmail dot com 2022-11-30 17:33 ` jakub at gcc dot gnu.org 2022-11-30 21:52 ` hjl.tools at gmail dot com 2023-05-30 13:44 ` cvs-commit at gcc dot gnu.org 2023-07-27 14:47 ` shaohua.li at inf dot ethz.ch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107172-4-FKjsXFEeoS@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).