[Bug libstdc++/107189] New: Inconsistent range insertion implementations in std::_Rb_tree in <bits/stl_tree.h>

[Bug libstdc++/107189] New: Inconsistent range insertion implementations in std::_Rb_tree in <bits/stl_tree.h>

[frankhb1989 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107189

            Bug ID: 107189
           Summary: Inconsistent range insertion implementations in
                    std::_Rb_tree in <bits/stl_tree.h>
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: frankhb1989 at gmail dot com
  Target Milestone: ---

//#if __cplusplus >= 201103L
      template<typename _InputIterator>
        __enable_if_t<__same_value_type<_InputIterator>::value>
        _M_insert_range_unique(_InputIterator __first, _InputIterator __last)
        {
          _Alloc_node __an(*this);
          for (; __first != __last; ++__first)
            _M_insert_unique_(end(), *__first, __an);
        }

      template<typename _InputIterator>
        __enable_if_t<!__same_value_type<_InputIterator>::value>
        _M_insert_range_unique(_InputIterator __first, _InputIterator __last)
        {
          for (; __first != __last; ++__first)
            _M_emplace_unique(*__first);
        }

      template<typename _InputIterator>
        __enable_if_t<__same_value_type<_InputIterator>::value>
        _M_insert_range_equal(_InputIterator __first, _InputIterator __last)
        {
          _Alloc_node __an(*this);
          for (; __first != __last; ++__first)
            _M_insert_equal_(end(), *__first, __an);
        }

      template<typename _InputIterator>
        __enable_if_t<!__same_value_type<_InputIterator>::value>
        _M_insert_range_equal(_InputIterator __first, _InputIterator __last)
        {
          _Alloc_node __an(*this);
          for (; __first != __last; ++__first)
            _M_emplace_equal(*__first);
        }

__an is not used in the 2nd overload of _M_insert_range_equal.

And is there any reason about not using _M_emplace_hint_{unique,equal} for
!__same_value_type cases?

[Bug libstdc++/107189] Inconsistent range insertion implementations in std::_Rb_tree in <bits/stl_tree.h>

[fdumont at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107189

François Dumont <fdumont at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-10-12
           Assignee|unassigned at gcc dot gnu.org      |fdumont at gcc dot gnu.org
     Ever confirmed|0                           |1
                 CC|                            |fdumont at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from François Dumont <fdumont at gcc dot gnu.org> ---
Code looks perfectly consistent to me. There is just this _Alloc_node
instantiation to remove.

Why do you want to call the _M_emplace_hint_{unique,equal} ? I rather wondered
why the __is_same_value_type alternatives are doing so just to pass end() as a
hint. And the answer is just that it is more convenient. Look at the
_M_insert_unique overloads to see that the one called is the most convenient
one.

Thanks for the report.

[Bug libstdc++/107189] Inconsistent range insertion implementations in std::_Rb_tree in <bits/stl_tree.h>

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107189

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Francois Dumont <fdumont@gcc.gnu.org>:

https://gcc.gnu.org/g:b3c9148cad2f6f05ef9bc0be34b65a62a7e236dd

commit r13-5125-gb3c9148cad2f6f05ef9bc0be34b65a62a7e236dd
Author: François Dumont <fdumont@gcc.gnu.org>
Date:   Wed Oct 12 19:34:01 2022 +0200

    libstdc++: Remove _Alloc_node instance in _Rb_tree [PR107189]

    libstdc++-v3/ChangeLog:

            PR libstdc++/107189
            * include/bits/stl_tree.h (_Rb_tree<>::_M_insert_range_equal):
Remove
            unused _Alloc_node instance.

[Bug libstdc++/107189] Inconsistent range insertion implementations in std::_Rb_tree in <bits/stl_tree.h>

[fdumont at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107189

François Dumont <fdumont at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |13.0

--- Comment #3 from François Dumont <fdumont at gcc dot gnu.org> ---
I am making this bug resolved for the useless _Alloc_node instance. Regarding
the inconsistent implementation feel free to open another issue with more
explanations.

Thanks