public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dcb314 at hotmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/107203] New: Possible missing sanity check in gofrontend/ast-dump.cc ?
Date: Mon, 10 Oct 2022 19:53:48 +0000	[thread overview]
Message-ID: <bug-107203-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107203

            Bug ID: 107203
           Summary: Possible missing sanity check in
                    gofrontend/ast-dump.cc ?
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Static analyser cppcheck says:

trunk.git/gcc/go/gofrontend/ast-dump.cc:267:8: warning: Missing bounds check
for extra iterator increment in loop. [StlMissingComparison]

Source code is

          ++it;
          (*it)->dump_expression(this);

I will ignore the dubious benefits of incrementing iterators in loops,
and just mention that a sanity for bounds might be wise before using 
the iterator.

             reply	other threads:[~2022-10-10 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 19:53 dcb314 at hotmail dot com [this message]
2022-10-10 20:04 ` [Bug go/107203] " dcb314 at hotmail dot com
2022-10-10 20:05 ` ian at airs dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107203-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).