public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug go/107203] New: Possible missing sanity check in gofrontend/ast-dump.cc ?
@ 2022-10-10 19:53 dcb314 at hotmail dot com
2022-10-10 20:04 ` [Bug go/107203] " dcb314 at hotmail dot com
2022-10-10 20:05 ` ian at airs dot com
0 siblings, 2 replies; 3+ messages in thread
From: dcb314 at hotmail dot com @ 2022-10-10 19:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107203
Bug ID: 107203
Summary: Possible missing sanity check in
gofrontend/ast-dump.cc ?
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: go
Assignee: ian at airs dot com
Reporter: dcb314 at hotmail dot com
Target Milestone: ---
Static analyser cppcheck says:
trunk.git/gcc/go/gofrontend/ast-dump.cc:267:8: warning: Missing bounds check
for extra iterator increment in loop. [StlMissingComparison]
Source code is
++it;
(*it)->dump_expression(this);
I will ignore the dubious benefits of incrementing iterators in loops,
and just mention that a sanity for bounds might be wise before using
the iterator.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug go/107203] Possible missing sanity check in gofrontend/ast-dump.cc ?
2022-10-10 19:53 [Bug go/107203] New: Possible missing sanity check in gofrontend/ast-dump.cc ? dcb314 at hotmail dot com
@ 2022-10-10 20:04 ` dcb314 at hotmail dot com
2022-10-10 20:05 ` ian at airs dot com
1 sibling, 0 replies; 3+ messages in thread
From: dcb314 at hotmail dot com @ 2022-10-10 20:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107203
--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
git blame says:
706cd57f714f (Roberto Lublinerman 2011-08-24 19:22:44 +0000 278) ++it;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug go/107203] Possible missing sanity check in gofrontend/ast-dump.cc ?
2022-10-10 19:53 [Bug go/107203] New: Possible missing sanity check in gofrontend/ast-dump.cc ? dcb314 at hotmail dot com
2022-10-10 20:04 ` [Bug go/107203] " dcb314 at hotmail dot com
@ 2022-10-10 20:05 ` ian at airs dot com
1 sibling, 0 replies; 3+ messages in thread
From: ian at airs dot com @ 2022-10-10 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107203
Ian Lance Taylor <ian at airs dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Ian Lance Taylor <ian at airs dot com> ---
Thanks, but the code is fine. It is only run when as_pairs is true, meaning
that the list consists of pairs of values.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-10 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 19:53 [Bug go/107203] New: Possible missing sanity check in gofrontend/ast-dump.cc ? dcb314 at hotmail dot com
2022-10-10 20:04 ` [Bug go/107203] " dcb314 at hotmail dot com
2022-10-10 20:05 ` ian at airs dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).