[Bug fortran/107214] New: [13 Regression] ICE: base pointer cycle detected

[Bug fortran/107214] New: [13 Regression] ICE: base pointer cycle detected

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

            Bug ID: 107214
           Summary: [13 Regression] ICE: base pointer cycle detected
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20220911 and 20220918 :


$ cat z1.f90
program p
   integer, allocatable :: a
   !$omp target map(tofrom: a, a)
   !$omp end target
end


$ gfortran-13-20221009 -c z1.f90 -fopenmp
when processing group:
map(tofrom:*a) map(alloc:a [pointer assign, bias: 0])
z1.f90:3:33:

    3 |    !$omp target map(tofrom: a, a)
      |                                 ^
internal compiler error: base pointer cycle detected
0xaee0b3 omp_tsort_mapping_groups_1
        ../../gcc/gimplify.cc:9571
0xaeded5 omp_tsort_mapping_groups_1
        ../../gcc/gimplify.cc:9614
0xb02820 omp_tsort_mapping_groups
        ../../gcc/gimplify.cc:9652
0xb02820 gimplify_scan_omp_clauses
        ../../gcc/gimplify.cc:10739
0xb08a0e gimplify_omp_workshare
        ../../gcc/gimplify.cc:15357
0xaf47ab gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        ../../gcc/gimplify.cc:16870
0xaf7ad8 gimplify_stmt(tree_node**, gimple**)
        ../../gcc/gimplify.cc:7187
0xaf59cb gimplify_statement_list
        ../../gcc/gimplify.cc:2021
0xaf59cb gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        ../../gcc/gimplify.cc:16773
0xaf7ad8 gimplify_stmt(tree_node**, gimple**)
        ../../gcc/gimplify.cc:7187
0xaf8031 gimplify_bind_expr
        ../../gcc/gimplify.cc:1430
0xaf503b gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        ../../gcc/gimplify.cc:16529
0xaf7ad8 gimplify_stmt(tree_node**, gimple**)
        ../../gcc/gimplify.cc:7187
0xaf8b7b gimplify_body(tree_node*, bool)
        ../../gcc/gimplify.cc:17588
0xaf8fcd gimplify_function_tree(tree_node*)
        ../../gcc/gimplify.cc:17787
0x9808d7 cgraph_node::analyze()
        ../../gcc/cgraphunit.cc:676
0x983267 analyze_functions
        ../../gcc/cgraphunit.cc:1240
0x983c1d symbol_table::finalize_compilation_unit()
        ../../gcc/cgraphunit.cc:2500

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |julian at codesourcery dot com,
                   |                            |marxin at gcc dot gnu.org
            Summary|[13 Regression] ICE: base   |[13 Regression] ICE: base
                   |pointer cycle detected      |pointer cycle detected
                   |                            |since
                   |                            |r13-2661-gb57abd072dd319a7
   Last reconfirmed|                            |2022-10-12

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-2661-gb57abd072dd319a7.

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |accepts-invalid
           Priority|P3                          |P1

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Julian Brown <jules@gcc.gnu.org>:

https://gcc.gnu.org/g:330b9a8d87dd73e10539da618496ad4964fee26d

commit r13-4703-g330b9a8d87dd73e10539da618496ad4964fee26d
Author: Julian Brown <julian@codesourcery.com>
Date:   Tue Dec 6 23:10:58 2022 +0000

    OpenMP: Duplicate checking for map clauses in Fortran (PR107214)

    This patch adds duplicate checking for OpenMP "map" clauses, taking some
    cues from the implementation for C in c-typeck.cc:c_finish_omp_clauses
    (and similar for C++).

    In addition to the existing use of the "mark" and "comp_mark" bitfields
    in the gfc_symbol structure, the patch adds several new bits handling
    duplicate checking within various categories of clause types.  If "mark"
    is being used for map clauses, we need to use different bits for other
    clauses for cases where "map" and some other clause can refer to the
    same symbol (e.g. "map(n) shared(n)").

    2022-12-06  Julian Brown  <julian@codesourcery.com>

    gcc/fortran/
            PR fortran/107214
            * gfortran.h (gfc_symbol): Add data_mark, dev_mark, gen_mark and
            reduc_mark bitfields.
            * openmp.cc (resolve_omp_clauses): Use above bitfields to improve
            duplicate clause detection.

    gcc/testsuite/
            PR fortran/107214
            * gfortran.dg/gomp/pr107214.f90: New test.
            * gfortran.dg/gomp/pr107214-2.f90: New test.
            * gfortran.dg/gomp/pr107214-3.f90: New test.
            * gfortran.dg/gomp/pr107214-4.f90: New test.
            * gfortran.dg/gomp/pr107214-5.f90: New test.
            * gfortran.dg/gomp/pr107214-6.f90: New test.
            * gfortran.dg/gomp/pr107214-7.f90: New test.
            * gfortran.dg/gomp/pr107214-8.f90: New test.

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #3 from anlauf at gcc dot gnu.org ---
Assuming it is fixed, can we close it?

[Bug fortran/107214] [13 Regression] ICE: base pointer cycle detected since r13-2661-gb57abd072dd319a7

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107214

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The #c0 testcase certainly doesn't ICE anymore.