[Bug modula2/107233] New: gm2 build hardcodes python3

[Bug modula2/107233] New: gm2 build hardcodes python3

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

            Bug ID: 107233
           Summary: gm2 build hardcodes python3
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

When trying to build the current devel/modula-2 branch on Solaris 11.3/SPARC
(only tried on 11.4 before), it fails trying to execute python3
unconditionally:

python3 /vol/gcc/src/hg/master/modula-2/gcc/m2/tools-src/def2texi.py -b./
-f/vol/gcc/src/hg/master/modula-2/gcc/m2/gm2-libs/Builtins.def >
/var/gcc/modula-2/11.4-gcc-modula-2/gcc/m2/Builtins.texi
/bin/ksh: python3: not found
make[3]: *** [/vol/gcc/src/hg/master/modula-2/gcc/m2/Make-lang.in:167:
Builtins.texi-check] Error 127

This happens because Solaris 11.3, unlike 11.4, has no python3 command.  It
only
provides python2.7 and python3.4.

I believe this could easily be fixed by using Automake's AM_PATH_PYTHON([3.0])
(or whatever minimal python 3.x version is required), substituting the
resulting
$PYTHON into Make-lang.in and the scripts that currently hardcode python3
instead.

[Bug modula2/107233] gm2 build hardcodes python3

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug modula2/107233] gm2 build hardcodes python3

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Now fixed.  configure.ac tests for python3 and Make-lang.in only invokes
python3 if it were found.

[Bug modula2/107233] gm2 build hardcodes python3

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
> Now fixed.  configure.ac tests for python3 and Make-lang.in only invokes
> python3 if it were found.

Confirmed on i386-pc-solaris2.11 (Solaris 11.3).  However, I still think
using AM_PATH_PYTHON as I've suggested initially to handle systems that
*do* have Python 3, but by another name (python3.4 here).  Right now,
only a couple of .texi files are missing, though, so the effect of
staying with you solution is minor.  I don't know if this will change in
the future if more depends on a working Python 3 installation.

Thanks.
        Rainer

[Bug modula2/107233] gm2 build hardcodes python3

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
ok, thanks for the suggestion.  I've changed gcc/configure.ac to use
AM_PATH_PYTHON and AM_CONDITIONAL:

# Python3?
AM_PATH_PYTHON(,, [:])
AM_CONDITIONAL([HAVE_PYTHON], [test "$PYTHON" != :])

[Bug modula2/107233] gm2 build hardcodes python3

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107233

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
> ok, thanks for the suggestion.  I've changed gcc/configure.ac to use
> AM_PATH_PYTHON and AM_CONDITIONAL:
>
> # Python3?
> AM_PATH_PYTHON(,, [:])
> AM_CONDITIONAL([HAVE_PYTHON], [test "$PYTHON" != :])

But wouldn't this pick up a version of python < 3.0 if nothing else is
present?  If the python code inside gcc/m2 does require 3.x, shouldn't
this be

AM_PATH_PYTHON([3.0],, [:])

(or whatever is the minimum) instead?