[Bug modula2/107234] New: Format error in m2pp.cc (m2pp_integer_cst)

[Bug modula2/107234] New: Format error in m2pp.cc (m2pp_integer_cst)

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107234

            Bug ID: 107234
           Summary: Format error in m2pp.cc (m2pp_integer_cst)
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

Created attachment 53695
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53695&action=edit
Proposed patch

Building the current devel/modula-2 branch on Solaris 11.3 fails:

/vol/gcc/src/hg/master/modula-2/gcc/m2/m2pp.cc: In function 'void
m2pp_integer_cst(pretty*, tree)':
/vol/gcc/src/hg/master/modula-2/gcc/m2/m2pp.cc:2067:26: warning: format '%lu'
expects argument of type 'long unsigned int', but argument 4 has type 'long
long unsigned int' [-Wformat=]
 2067 |   snprintf (val, 100, "%lud", TREE_INT_CST_LOW (t));
      |                        ~~^
      |                          |
      |                          long unsigned int
      |                        %llu

This should use HOST_WIDE_INT_PRINT_UNSIGNED instead of hardcoding a specific
format.

[Bug modula2/107234] Format error in m2pp.cc (m2pp_integer_cst)

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107234

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug modula2/107234] Format error in m2pp.cc (m2pp_integer_cst)

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107234

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-02-06

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed and many thanks for the patch.

[Bug modula2/107234] Format error in m2pp.cc (m2pp_integer_cst)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107234

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:17d0892d61a82a338925c81853b45eb8b4929fc0

commit r13-5721-g17d0892d61a82a338925c81853b45eb8b4929fc0
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Feb 6 18:50:18 2023 +0000

    Format error in m2pp.cc (m2pp_integer_cst) [PR107234]

    Use HOST_WIDE_INT_PRINT_UNSIGNED instead of hardcoding a
    specific format.

    gcc/m2/ChangeLog:

            * m2pp.cc (m2pp_integer_cst): Use
            HOST_WIDE_INT_PRINT_UNSIGNED as the format specifier.

            PR modula2/107234
                Co-Authored by: Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/107234] Format error in m2pp.cc (m2pp_integer_cst)

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107234

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now as patch has been applied.