[Bug c++/107291] New: [12/13 Regression] ICE in build_comparison_op, at cp/method.cc:1461

[Bug c++/107291] New: [12/13 Regression] ICE in build_comparison_op, at cp/method.cc:1461

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

            Bug ID: 107291
           Summary: [12/13 Regression] ICE in build_comparison_op, at
                    cp/method.cc:1461
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

g++ 13.0.0 20221016 snapshot (g:6366e3e8847af98d4728d55951534769d034d02a) ICEs
when compiling the following testcase, extracted from
test/CXX/class/class.compare/class.compare.default/p1.cpp from the flang 15.0.1
test suite, w/ -std=c++20:

struct S4;
bool operator==(S4 const &, S4 const &) = default;

% g++-13 -std=c++20 -c ean6w24q.cpp
ean6w24q.cpp:2:6: error: defaulted 'bool operator==(const S4&, const S4&)' is
not a friend of 'S4'
    2 | bool operator==(S4 const &, S4 const &) = default;
      |      ^~~~~~~~
ean6w24q.cpp: In function 'constexpr bool operator==(const S4&, const S4&)':
ean6w24q.cpp:2:6: internal compiler error: in build_comparison_op, at
cp/method.cc:1461
0x6eb1f1 build_comparison_op(tree_node*, bool, int)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/method.cc:1461
0xa8dc5e synthesize_method(tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/method.cc:1823
0xa34889 cp_finish_decl(tree_node*, tree_node*, bool, tree_node*, int)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/decl.cc:8594
0xb2ef94 cp_parser_init_declarator
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:22895
0xb06cc9 cp_parser_simple_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:15284
0xb3a9a1 cp_parser_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:14970
0xb3b4e9 cp_parser_toplevel_declaration
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:14991
0xb3b4e9 cp_parser_translation_unit
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:5076
0xb3b4e9 c_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/cp/parser.cc:48860
0xc7bab1 c_common_parse_file()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221016/work/gcc-13-20221016/gcc/c-family/c-opts.cc:1247

[Bug c++/107291] [12/13 Regression] ICE in build_comparison_op, at cp/method.cc:1461

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |error-recovery
   Target Milestone|---                         |12.3

[Bug c++/107291] [12/13 Regression] ICE in build_comparison_op, at cp/method.cc:1461

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug c++/107291] [12/13 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
            Summary|[12/13 Regression] ICE in   |[12/13 Regression] ICE in
                   |build_comparison_op, at     |build_comparison_op, at
                   |cp/method.cc:1461           |cp/method.cc:1461 since
                   |                            |r12-4202-g09d886e671f2230a

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Likely started with r12-4202-g09d886e671f2230a.

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.3                        |12.4

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 12.3 is being released, retargeting bugs to GCC 12.4.

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stevenxia990430 at gmail dot com

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 110837 has been marked as a duplicate of this bug. ***

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
   Last reconfirmed|                            |2024-02-06
             Status|UNCONFIRMED                 |ASSIGNED

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:c5d34912ad576be1ef19be92f7eabde54b9089eb

commit r14-8817-gc5d34912ad576be1ef19be92f7eabde54b9089eb
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 5 19:56:45 2024 -0500

    c++: defaulted op== for incomplete class [PR107291]

    After complaining about lack of friendship, we should not try to go on and
    define the defaulted comparison operator anyway.

            PR c++/107291

    gcc/cp/ChangeLog:

            * method.cc (early_check_defaulted_comparison): Fail if not friend.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/spaceship-eq17.C: New test.

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:67ac78caf31f7cb3202177e6428a46d829b70f23

commit r13-8285-g67ac78caf31f7cb3202177e6428a46d829b70f23
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 5 19:56:45 2024 -0500

    c++: defaulted op== for incomplete class [PR107291]

    After complaining about lack of friendship, we should not try to go on and
    define the defaulted comparison operator anyway.

            PR c++/107291

    gcc/cp/ChangeLog:

            * method.cc (early_check_defaulted_comparison): Fail if not friend.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/spaceship-eq17.C: New test.

    (cherry picked from commit c5d34912ad576be1ef19be92f7eabde54b9089eb)

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:db8d5b0ad074344559b3201e567c1e47e65d0bdd

commit r12-10138-gdb8d5b0ad074344559b3201e567c1e47e65d0bdd
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 5 19:56:45 2024 -0500

    c++: defaulted op== for incomplete class [PR107291]

    After complaining about lack of friendship, we should not try to go on and
    define the defaulted comparison operator anyway.

            PR c++/107291

    gcc/cp/ChangeLog:

            * method.cc (early_check_defaulted_comparison): Fail if not friend.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp2a/spaceship-eq17.C: New test.

    (cherry picked from commit c5d34912ad576be1ef19be92f7eabde54b9089eb)

[Bug c++/107291] [12/13/14 Regression] ICE in build_comparison_op, at cp/method.cc:1461 since r12-4202-g09d886e671f2230a

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107291

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for 12.4/13.3/14.