[Bug analyzer/107349] New: [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[Bug analyzer/107349] New: [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107349

            Bug ID: 107349
           Summary: [13 Regression] ICE in get_va_copy_arg, at
                    analyzer/varargs.cc:175
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: acoplan at gcc dot gnu.org
  Target Milestone: ---

The following fails on aarch64:

$ cat t.c
void f() {
  __builtin_va_list x,y;
  __builtin_va_copy(x,y);
}
$ gcc/xgcc -B gcc -c t.c -fanalyzer
during IPA pass: analyzer
t.c: In function ‘f’:
t.c:3:3: internal compiler error: in get_va_copy_arg, at
analyzer/varargs.cc:175
    3 |   __builtin_va_copy(x,y);
      |   ^~~~~~~~~~~~~~~~~~~~~~
0x13d26cb get_va_copy_arg
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/varargs.cc:175
0x13d3a47 ana::region_model::impl_call_va_copy(ana::call_details const&)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/varargs.cc:696
0x136742b ana::region_model::on_call_pre(gcall const*,
ana::region_model_context*, bool*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:2246
0x13707f7 ana::region_model::on_stmt_pre(gimple const*, bool*, bool*,
ana::region_model_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/region-model.cc:1262
0x133706f ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*, ana::uncertainty_t*,
ana::path_context*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:1447
0x1339a2b ana::exploded_graph::process_node(ana::exploded_node*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:4034
0x133a6a3 ana::exploded_graph::process_worklist()
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:3436
0x133c847 ana::impl_run_checkers(ana::logger*)
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:6084
0x133dd73 ana::run_checkers()
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/engine.cc:6158
0x132ce5b execute
        /home/alecop01/toolchain/src/gcc/gcc/analyzer/analyzer-pass.cc:86
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

this was reduced from the analyzer testsuite where I see the following tests
failing due to this:

gcc.dg/analyzer/stdarg-1.c
gcc.dg/analyzer/call-summaries-2.c
gcc.dg/analyzer/stdarg-2.c

I think this might have started with
r13-3390-gebe87edadc4a3f15a6a0d0c1d4a198e0ea37d8b5

[Bug analyzer/107349] [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107349

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug analyzer/107349] [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107349

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-10-24
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Confirmed; am working on a fix.  Sorry for the breakage.

[Bug analyzer/107349] [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107349

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:687d11fd74e7de724d46d3e0c58eb012db93ec2b

commit r13-3470-g687d11fd74e7de724d46d3e0c58eb012db93ec2b
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Mon Oct 24 16:41:09 2022 -0400

    analyzer: fix ICE on va_copy [PR107349]

    gcc/analyzer/ChangeLog:
            PR analyzer/107349
            * varargs.cc (get_va_copy_arg): Fix the non-pointer case.

    gcc/testsuite/ChangeLog:
            PR analyzer/107349
            * gcc.dg/analyzer/stdarg-1-ms_abi.c (pr107349): New.
            * gcc.dg/analyzer/stdarg-1-sysv_abi.c (pr107349): New.
            * gcc.dg/analyzer/stdarg-1.c (pr107349): New.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/107349] [13 Regression] ICE in get_va_copy_arg, at analyzer/varargs.cc:175

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107349

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed by the above patch (tested lightly with aarch64-unknown-linux).

Thanks for reporting this; sorry again about the breakage.