public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/107377] New: Warn about duplicate enum values?
@ 2022-10-24 13:38 marxin at gcc dot gnu.org
  2022-10-24 15:24 ` [Bug c/107377] " pinskia at gcc dot gnu.org
  2022-10-24 15:25 ` pinskia at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-10-24 13:38 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107377

            Bug ID: 107377
           Summary: Warn about duplicate enum values?
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: mpolacek at gcc dot gnu.org
  Target Milestone: ---

Noticed that while investigating PR107364:

enum processor_vendor
{
  VENDOR_INTEL = 1,
  VENDOR_AMD,
  VENDOR_ZHAOXIN,
  VENDOR_OTHER,
  VENDOR_CENTAUR,
  VENDOR_CYRIX,
  VENDOR_NSC,
  BUILTIN_VENDOR_MAX = VENDOR_OTHER,
  VENDOR_MAX
};

As one can see VENDOR_CENTAUR == 5, but VENDOR_MAX is also == 5 as
BUILTIN_VENDOR_MAX points to 4 and thus VENDOR_MAX == 5.

Maybe we can warn about 2 enum values that have the same value and none of them
is defined with '= some_value'. What do you think?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug c/107377] Warn about duplicate enum values?
  2022-10-24 13:38 [Bug c/107377] New: Warn about duplicate enum values? marxin at gcc dot gnu.org
@ 2022-10-24 15:24 ` pinskia at gcc dot gnu.org
  2022-10-24 15:25 ` pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-10-24 15:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107377

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug c/107377] Warn about duplicate enum values?
  2022-10-24 13:38 [Bug c/107377] New: Warn about duplicate enum values? marxin at gcc dot gnu.org
  2022-10-24 15:24 ` [Bug c/107377] " pinskia at gcc dot gnu.org
@ 2022-10-24 15:25 ` pinskia at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-10-24 15:25 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107377

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Dup of much older bug 16186.

*** This bug has been marked as a duplicate of bug 16186 ***

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-24 15:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-24 13:38 [Bug c/107377] New: Warn about duplicate enum values? marxin at gcc dot gnu.org
2022-10-24 15:24 ` [Bug c/107377] " pinskia at gcc dot gnu.org
2022-10-24 15:25 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).