public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/107385] [asm goto] "=r" vs "+r" for outputs along indirect edges
Date: Mon, 24 Oct 2022 18:59:17 +0000	[thread overview]
Message-ID: <bug-107385-4-GwSJmMB9hh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107385-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107385

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-10-24

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Expand is doing:

(insn 3 24 9 6 (set (reg/v:SI 82 [ <retval> ])
        (const_int 6 [0x6])) "/app/example.cpp":4:7 -1
     (nil))
(insn 9 3 14 6 (set (reg/v:SI 82 [ <retval> ])
        (reg:SI 83 [ x ])) "/app/example.cpp":3:5 -1
     (nil))


From this IR:
  <bb 2> [local count: 1073741824]:
  __asm__ goto("//" : "=r" x_2 :  :  : "bar" <L3>);
  goto <bb 4>; [35.00%]

  <bb 3> [local count: 697932184]:
<L3>:

  <bb 4> [local count: 1073741824]:
  # x_1 = PHI <x_2(3), 6(2)>
bar:

Note 6 does not need to be a constant here, it could be anything.
I suspect when the inline-asm goto is being expanded, it adds the assignment to
reg 82 on all edges going out of the inline-asm but then messing up because
there is some extra code due to the phi node.

  reply	other threads:[~2022-10-24 18:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 18:37 [Bug c/107385] New: " ndesaulniers at google dot com
2022-10-24 18:59 ` pinskia at gcc dot gnu.org [this message]
2024-02-15  8:21 ` [Bug middle-end/107385] " jakub at gcc dot gnu.org
2024-02-15 13:07 ` jakub at gcc dot gnu.org
2024-02-15 13:07 ` jakub at gcc dot gnu.org
2024-02-15 14:56 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:15 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:17 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:21 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:06 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:08 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:08 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:09 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107385-4-GwSJmMB9hh@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).