public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ndesaulniers at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/107385] New: [asm goto] "=r" vs "+r" for outputs along indirect edges
Date: Mon, 24 Oct 2022 18:37:46 +0000	[thread overview]
Message-ID: <bug-107385-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107385

            Bug ID: 107385
           Summary: [asm goto] "=r" vs "+r" for outputs along indirect
                    edges
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ndesaulniers at google dot com
                CC: isanbard at gmail dot com
  Target Milestone: ---

I was playing around with adding support for outputs along indirect edges of
asm goto in clang.  When I was comparing codegen between various cases, I
noticed a case that looked like a bug to me:

int foo (void) {
    int x;
    asm goto ("": "=r"(x) ::: bar);
    x = 6;
bar:
    return x;
}

in gcc 12.2 with `-O2` produces:

foo:
        ret

The write to x from the inline asm should be dead along the fallthough or
default path out of the asm goto.  We should have one edge that assigns 6 to
the output.

Changing the output constraint modifier from =r to +r seems to produce the
expected code.

https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Extended-Asm mentions

> Be careful when you set output operands inside asm goto only on some possible control flow paths. If you don’t set up the output on given path and never use it on this path, it is okay. Otherwise, you should use ‘+’ constraint modifier meaning that the operand is input and output one. With this modifier you will have the correct values on all possible paths from the asm goto.

I'm not sure if that comment is alluding to this behavior, but it might be nice
to not have to pass in any prior value for output only variables?

             reply	other threads:[~2022-10-24 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 18:37 ndesaulniers at google dot com [this message]
2022-10-24 18:59 ` [Bug middle-end/107385] " pinskia at gcc dot gnu.org
2024-02-15  8:21 ` jakub at gcc dot gnu.org
2024-02-15 13:07 ` jakub at gcc dot gnu.org
2024-02-15 13:07 ` jakub at gcc dot gnu.org
2024-02-15 14:56 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:15 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:17 ` cvs-commit at gcc dot gnu.org
2024-02-15 15:21 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:06 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:08 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:08 ` cvs-commit at gcc dot gnu.org
2024-02-15 19:09 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107385-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).