public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/107424] [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 - and wrong code - with non-rectangular loops
Date: Fri, 13 Jan 2023 10:53:49 +0000	[thread overview]
Message-ID: <bug-107424-4-50PCVgOlR4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107424-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107424

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
For completeness, the C testcase to previous comment (comment 3) is as follows.
Contrary to Fortran, I put a 'lastprivate' to all variables – to match the
current
patch (→ see (A) in comment 3).

  int n,m,p, i,j,k;
  n = 11; m = 23; p = 27;
  #pragma omp simd collapse(3) lastprivate(k) lastprivate(i) lastprivate(j)
  for (i = 1; i <= n; i++)
    for (j = 1; j <= m; j++)
      for (k = j - 41; k <= p; k++)
        if (k < 1 - 41 || k > p)
          __builtin_printf ("%d %d %d\n", i, j, k);
  if (i != n + 1) __builtin_abort ();
  if (j != m + 1) __builtin_abort ();
  if (k != p + 1) __builtin_abort ();

The code works fine. The original dump is also the same, except for the '* 1':
  #pragma omp simd lastprivate(j) lastprivate(i) lastprivate(k) collapse(3)
     ...
      for (k = j * 1 + -41; k <= p; k++ )

but in the gimple dump, the result is:
    #pragma omp simd lastprivate(j) lastprivate(i) lastprivate(k) collapse(3) \
                     private(k.2) private(j.1) private(i.0)
    for (i.0 = 1; i.0 <= n; i.0 = i.0 + 1)
      for (j.1 = 1; j.1 <= m; j.1 = j.1 + 1)
        for (k.2 = j.1 * 1 + -41; k.2 <= p; k.2 = k.2 + 1)

where 'j' has been replaced by 'j.1' and not been hosted before the loop.

  parent reply	other threads:[~2023-01-13 10:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 18:37 [Bug fortran/107424] New: [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 gscfq@t-online.de
2022-10-27  8:50 ` [Bug fortran/107424] " marxin at gcc dot gnu.org
2022-10-28 11:35 ` rguenth at gcc dot gnu.org
2023-01-11 15:30 ` [Bug fortran/107424] [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 - and wrong code - with non-rectangular loops burnus at gcc dot gnu.org
2023-01-11 15:59 ` burnus at gcc dot gnu.org
2023-01-13 10:46 ` burnus at gcc dot gnu.org
2023-01-13 10:53 ` burnus at gcc dot gnu.org [this message]
2023-01-13 11:07 ` jakub at gcc dot gnu.org
2023-01-13 11:46 ` burnus at gcc dot gnu.org
2023-01-13 11:51 ` jakub at gcc dot gnu.org
2023-01-18 22:24 ` burnus at gcc dot gnu.org
2023-01-25 14:50 ` burnus at gcc dot gnu.org
2023-02-09 14:51 ` cvs-commit at gcc dot gnu.org
2023-02-09 14:54 ` burnus at gcc dot gnu.org
2023-04-26  6:56 ` [Bug fortran/107424] [13/14 " rguenth at gcc dot gnu.org
2023-07-17 11:15 ` burnus at gcc dot gnu.org
2023-07-19  8:19 ` cvs-commit at gcc dot gnu.org
2023-07-19  8:27 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107424-4-50PCVgOlR4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).