public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/107424] [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 - and wrong code - with non-rectangular loops Date: Wed, 11 Jan 2023 15:59:57 +0000 [thread overview] Message-ID: <bug-107424-4-VqrWciynAe@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107424-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107424 --- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> --- Commenting out the 'gcc_assert' of comment 0, it compiles and produces the following dump. I don't understand why there is a 'lastprivate' – and 'i' in the bounds are wrong: for the first iteration, it is undefined and otherwise, it lags always behind. #pragma omp simd lastprivate(count.0) collapse(2) for (count.0 = 0; count.0 < 5; count.0 = count.0 + 1) for (j = 1; j <= i; j = j + 1) { i = count.0 * 2 + 1; L.1:; } And yet another variant: !$omp do simd collapse(2) do i = 1, 9, 2 do j = 1, i, 2 i.e. both with non-unit strides. Then the result is still an ICE; commenting the assert, the result is: D.4265 = (i + 1) / 2; // Ups! This should use 'count.1' and shall not be hoisted! #pragma omp for collapse(2) { { #pragma omp simd lastprivate(count.1) lastprivate(count.0) collapse(2) for (count.0 = 0; count.0 < 5; count.0 = count.0 + 1) for (count.1 = 0; count.1 < D.4265; count.1 = count.1 + 1) { i = count.0 * 2 + 1; j = count.1 * 2 + 1; L.1:; } Here, COUNT is used in the inner loop - that would be also the option for the stride==1 case, but as the expression needs to be in the condition already, it might be better to have for inner stride == 1: for (j = 1; j <= count.0 * 2 + 1; j = j + 1) and for inner stride == 2: for (j = 1; j <= (count.0 * 2 + 1 + 1) / 2; j = j + 1) We probably need to check whether any of lb,ub,stride contains a parent loop var.
next prev parent reply other threads:[~2023-01-11 15:59 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-26 18:37 [Bug fortran/107424] New: [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 gscfq@t-online.de 2022-10-27 8:50 ` [Bug fortran/107424] " marxin at gcc dot gnu.org 2022-10-28 11:35 ` rguenth at gcc dot gnu.org 2023-01-11 15:30 ` [Bug fortran/107424] [13 Regression] ICE in gfc_trans_omp_do, at fortran/trans-openmp.cc:5397 - and wrong code - with non-rectangular loops burnus at gcc dot gnu.org 2023-01-11 15:59 ` burnus at gcc dot gnu.org [this message] 2023-01-13 10:46 ` burnus at gcc dot gnu.org 2023-01-13 10:53 ` burnus at gcc dot gnu.org 2023-01-13 11:07 ` jakub at gcc dot gnu.org 2023-01-13 11:46 ` burnus at gcc dot gnu.org 2023-01-13 11:51 ` jakub at gcc dot gnu.org 2023-01-18 22:24 ` burnus at gcc dot gnu.org 2023-01-25 14:50 ` burnus at gcc dot gnu.org 2023-02-09 14:51 ` cvs-commit at gcc dot gnu.org 2023-02-09 14:54 ` burnus at gcc dot gnu.org 2023-04-26 6:56 ` [Bug fortran/107424] [13/14 " rguenth at gcc dot gnu.org 2023-07-17 11:15 ` burnus at gcc dot gnu.org 2023-07-19 8:19 ` cvs-commit at gcc dot gnu.org 2023-07-19 8:27 ` burnus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107424-4-VqrWciynAe@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).