public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression]
@ 2022-11-02 19:24 dcb314 at hotmail dot com
2022-11-02 19:30 ` [Bug target/107510] " pinskia at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: dcb314 at hotmail dot com @ 2022-11-02 19:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510
Bug ID: 107510
Summary: gcc/config/gcn/gcn.cc:4930:9: style: Same expression
on both sides of '||'. [duplicateExpression]
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: dcb314 at hotmail dot com
Target Milestone: ---
Source code is
bool use_moves = (((unspec == UNSPEC_SMIN_DPP_SHR
|| unspec == UNSPEC_SMIN_DPP_SHR
Another small problem found by static analyser cppcheck.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/107510] gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com @ 2022-11-02 19:30 ` pinskia at gcc dot gnu.org 2022-11-03 9:52 ` ams at gcc dot gnu.org ` (3 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2022-11-02 19:30 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target|gcn |amdgcn-*-* Last reconfirmed| |2022-11-02 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> --- Confirmed. It just looks like a copy and pasto and not really causing any issues: bool use_moves = (((unspec == UNSPEC_SMIN_DPP_SHR || unspec == UNSPEC_SMIN_DPP_SHR || unspec == UNSPEC_SMAX_DPP_SHR || unspec == UNSPEC_UMIN_DPP_SHR || unspec == UNSPEC_UMAX_DPP_SHR) && (scalar_mode == DImode || scalar_mode == DFmode)) || (unspec == UNSPEC_PLUS_DPP_SHR && scalar_mode == DFmode)); rtx_code code = (unspec == UNSPEC_SMIN_DPP_SHR ? SMIN : unspec == UNSPEC_SMIN_DPP_SHR ? SMIN : unspec == UNSPEC_SMAX_DPP_SHR ? SMAX : unspec == UNSPEC_UMIN_DPP_SHR ? UMIN : unspec == UNSPEC_UMAX_DPP_SHR ? UMAX : unspec == UNSPEC_PLUS_DPP_SHR ? PLUS : UNKNOWN); bool use_extends = ((unspec == UNSPEC_SMIN_DPP_SHR || unspec == UNSPEC_SMAX_DPP_SHR || unspec == UNSPEC_UMIN_DPP_SHR || unspec == UNSPEC_UMAX_DPP_SHR) && (scalar_mode == QImode || scalar_mode == HImode)); It was added afterwards too: r13-3574-gf539029c1ce6fb ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/107510] gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com 2022-11-02 19:30 ` [Bug target/107510] " pinskia at gcc dot gnu.org @ 2022-11-03 9:52 ` ams at gcc dot gnu.org 2022-11-03 10:21 ` cvs-commit at gcc dot gnu.org ` (2 subsequent siblings) 4 siblings, 0 replies; 6+ messages in thread From: ams at gcc dot gnu.org @ 2022-11-03 9:52 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510 Andrew Stubbs <ams at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at gcc dot gnu.org |ams at gcc dot gnu.org Status|NEW |ASSIGNED --- Comment #2 from Andrew Stubbs <ams at gcc dot gnu.org> --- Oops, I thought I fixed that. :( ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/107510] gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com 2022-11-02 19:30 ` [Bug target/107510] " pinskia at gcc dot gnu.org 2022-11-03 9:52 ` ams at gcc dot gnu.org @ 2022-11-03 10:21 ` cvs-commit at gcc dot gnu.org 2022-11-03 10:22 ` ams at gcc dot gnu.org 2022-11-28 22:06 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2022-11-03 10:21 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510 --- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Andrew Stubbs <ams@gcc.gnu.org>: https://gcc.gnu.org/g:f95e4eced20666a981881f76d66d997922648687 commit r13-3622-gf95e4eced20666a981881f76d66d997922648687 Author: Andrew Stubbs <ams@codesourcery.com> Date: Thu Nov 3 09:55:41 2022 +0000 amdgcn: Fix duplicate conditionals [PR107510] Just a harmless cut-and-paste issue. PR target/107510 gcc/ChangeLog: * config/gcn/gcn.cc (gcn_expand_reduc_scalar): Remove duplicate UNSPEC_SMIN_DPP_SHR conditionals. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/107510] gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com ` (2 preceding siblings ...) 2022-11-03 10:21 ` cvs-commit at gcc dot gnu.org @ 2022-11-03 10:22 ` ams at gcc dot gnu.org 2022-11-28 22:06 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: ams at gcc dot gnu.org @ 2022-11-03 10:22 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510 Andrew Stubbs <ams at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Andrew Stubbs <ams at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/107510] gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com ` (3 preceding siblings ...) 2022-11-03 10:22 ` ams at gcc dot gnu.org @ 2022-11-28 22:06 ` pinskia at gcc dot gnu.org 4 siblings, 0 replies; 6+ messages in thread From: pinskia at gcc dot gnu.org @ 2022-11-28 22:06 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107510 Andrew Pinski <pinskia at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |13.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-28 22:06 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-11-02 19:24 [Bug c/107510] New: gcc/config/gcn/gcn.cc:4930:9: style: Same expression on both sides of '||'. [duplicateExpression] dcb314 at hotmail dot com 2022-11-02 19:30 ` [Bug target/107510] " pinskia at gcc dot gnu.org 2022-11-03 9:52 ` ams at gcc dot gnu.org 2022-11-03 10:21 ` cvs-commit at gcc dot gnu.org 2022-11-03 10:22 ` ams at gcc dot gnu.org 2022-11-28 22:06 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).