[Bug c++/107511] New: [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[Bug c++/107511] New: [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[mckelvey at maskull dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

            Bug ID: 107511
           Summary: [13 Regression] gcc-13-20221030 failure to build on
                    Cygwin due to lack of secure_getenv
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mckelvey at maskull dot com
  Target Milestone: ---

Created attachment 53822
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53822&action=edit
Build log

libtool: compile: 
/home/McKelvey/gcc-13-20221030/host-x86_64-pc-cygwin/gcc/xgcc -shared-libgcc
-B/home/McKelvey/gcc-13-20221030/host-x86_64-pc-cygwin/gcc -nostdinc++
-L/home/McKelvey/gcc-13-20221030/x86_64-pc-cygwin/libstdc++-v3/src
-L/home/McKelvey/gcc-13-20221030/x86_64-pc-cygwin/libstdc++-v3/src/.libs
-L/home/McKelvey/gcc-13-20221030/x86_64-pc-cygwin/libstdc++-v3/libsupc++/.libs
-B/usr/local/x86_64-pc-cygwin/bin/ -B/usr/local/x86_64-pc-cygwin/lib/ -isystem
/usr/local/x86_64-pc-cygwin/include -isystem
/usr/local/x86_64-pc-cygwin/sys-include -fno-checking
-I/home/McKelvey/gcc-13-20221030/libstdc++-v3/../libgcc
-I/home/McKelvey/gcc-13-20221030/x86_64-pc-cygwin/libstdc++-v3/include/x86_64-pc-cygwin
-I/home/McKelvey/gcc-13-20221030/x86_64-pc-cygwin/libstdc++-v3/include
-I/home/McKelvey/gcc-13-20221030/libstdc++-v3/libsupc++ -D_GLIBCXX_SHARED
-fno-implicit-templates -Wall -Wextra -Wwrite-strings -Wcast-qual -Wabi=2
-fdiagnostics-show-location=once -ffunction-sections -fdata-sections
-frandom-seed=eh_alloc.lo -g -O2 -c
../../.././libstdc++-v3/libsupc++/eh_alloc.cc -o eh_alloc.o
../../.././libstdc++-v3/libsupc++/eh_alloc.cc: In constructor
‘{anonymous}::pool::pool()’:
../../.././libstdc++-v3/libsupc++/eh_alloc.cc:190:27: error: ‘::secure_getenv’
has not been declared
  190 |       const char* str = ::secure_getenv("GLIBCXX_TUNABLES");

$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-pc-cygwin/13.0.0/lto-wrapper.exe
Target: x86_64-pc-cygwin
Configured with: ./configure --enable-languages=c,c++ --enable-threads=posix
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20221030 (experimental) (GCC)

$ uname
CYGWIN_NT-10.0-19044

Windows 10

See 105540 and 104217 for gcc-11 and 12 fixes.

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect adding:
#ifndef _GNU_SOURCE
// Cygwin needs this for secure_getenv
# define _GNU_SOURCE 1
#endif

at the beginging of eh_alloc.cc fixes the issue; just like what was done for
src/c++17/fs_ops.cc, src/filesystem/dir.cc, etc.

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-11-02
           Keywords|                            |build
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Sigh, this is what I get for using AC_CHECK_FUNCS(secure_getenv) instead of
writing my own check that would actually do the right thing.

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:f505f37a8e5a7646af4038b5c46f72d8a05dc7f0

commit r13-3684-gf505f37a8e5a7646af4038b5c46f72d8a05dc7f0
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 3 11:44:47 2022 +0000

    libstdc++: Define _GNU_SOURCE for secure_getenv on Cygwin [PR107511]

    As in r12-6867-ge20486d508afdf we need to define _GNU_SOURCE explicitly
    for Cygwin, because configure finds it in libc but it isn't declared
    unless we request it.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107511
            * libsupc++/eh_alloc.cc (_GNU_SOURCE): Define.

[Bug libstdc++/107511] [13 Regression] gcc-13-20221030 failure to build on Cygwin due to lack of secure_getenv

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107511

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Should be fixed now.