public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/107517] [OpenMP][5.0] 'target update' with strides — for C/C++ and Fortran
Date: Thu, 03 Nov 2022 13:48:05 +0000	[thread overview]
Message-ID: <bug-107517-4-jM8nF0eFHr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107517-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107517

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
OpenMP 4.5 had:
"If a list item is an array section it must specify contiguous storage."
restriction on target update, which got dropped in 5.0.
For the implementation, I think we have multiple possibilities.
One is to do what we'll need to do e.g. for map clause with iterators (that is
5.1 feature which we still don't implement), so basically arrange for having a
VLA for GOMP_target* arrays and fill them with runtime loops.
Or add some new GOMP_MAP_* to represent record that will describe some strided
mapping or to/from update, perhaps pointing to arguments like
omp_target_memcpy_rect has to describe, and let the library handle it.
Or a mixture thereof.
If it is easily describable, advantage of handling it on the library side would
be that we could use some smarter host to device or vice versa copying if a
plugin supports them (I think Cuda has some support but I think we don't use it
even for omp_target_memcpy_rect).

      reply	other threads:[~2022-11-03 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 13:18 [Bug middle-end/107517] New: " burnus at gcc dot gnu.org
2022-11-03 13:48 ` jakub at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107517-4-jM8nF0eFHr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).