[Bug rtl-optimization/107585] New: [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[Bug rtl-optimization/107585] New: [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107585

            Bug ID: 107585
           Summary: [13 Regression] ICE: in decompose, at rtl.h:2288 at -O
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 53858
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53858&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O testcase.c 
testcase.c:10:1: internal compiler error: in decompose, at rtl.h:2288
   10 | }
      | ^
0x7979da wi::int_traits<std::pair<rtx_def*, machine_mode> >::decompose(long*,
unsigned int, std::pair<rtx_def*, machine_mode> const&)
        /repo/gcc-trunk/gcc/rtl.h:2288
0x7979da wide_int_ref_storage<false,
true>::wide_int_ref_storage<std::pair<rtx_def*, machine_mode>
>(std::pair<rtx_def*, machine_mode> const&)
        /repo/gcc-trunk/gcc/wide-int.h:1024
0x7979da generic_wide_int<wide_int_ref_storage<false, true>
>::generic_wide_int<std::pair<rtx_def*, machine_mode> >(std::pair<rtx_def*,
machine_mode> const&)
        /repo/gcc-trunk/gcc/wide-int.h:782
0x7979da native_encode_rtx(machine_mode, rtx_def*, vec<unsigned char, va_heap,
vl_ptr>&, unsigned int, unsigned int)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7007
0x13b7298 native_encode_rtx(machine_mode, rtx_def*, vec<unsigned char, va_heap,
vl_ptr>&, unsigned int, unsigned int)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:6977
0x174ec46 optimize_constant_pool
        /repo/gcc-trunk/gcc/varasm.cc:4416
0x17587cf output_shared_constant_pool()
        /repo/gcc-trunk/gcc/varasm.cc:4523
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-3822-20221108213455-gb305793b985-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/13.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-3822-20221108213455-gb305793b985-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20221109 (experimental) (GCC)

[Bug target/107585] [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107585

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|rtl-optimization            |target
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=107546
   Target Milestone|---                         |13.0

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely introduced by r13-3803-gfa271afb58423014e2feef9f15c1a87428e64ddc .

[Bug target/107585] [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107585

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2022-11-09
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 53860
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53860&action=edit
gcc13-pr107585.patch

Untested fix.

[Bug target/107585] [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107585

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:49de156a6adb50e0624479f22c20141cadef812d

commit r13-3874-g49de156a6adb50e0624479f22c20141cadef812d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Nov 10 11:46:52 2022 +0100

    i386: Fix up ix86_expand_int_sse_cmp [PR107585]

    The following patch fixes ICE on the testcase.  I've used GEN_INT
    incorrectly thinking the code punts on the problematic boundaries.
    It does, but only for LE and GE, i.e. signed comparisons, for unsigned
    the boundaries are 0 and unsigned maximum, so when say unsigned char
    adds one to 127 or subtracts one from 128 we need to canonicalize it.

    2022-11-10  Jakub Jelinek  <jakub@redhat.com>

            PR target/107585
            PR target/107546
            * config/i386/i386-expand.cc (ix86_expand_int_sse_cmp): Use
            gen_int_mode rather than GEN_INT.

            * gcc.dg/pr107585.c: New test.

[Bug target/107585] [13 Regression] ICE: in decompose, at rtl.h:2288 at -O

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107585

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.