public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook
@ 2022-11-10 1:04 pinskia at gcc dot gnu.org
2022-11-10 1:04 ` [Bug middle-end/107601] " pinskia at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-10 1:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107601
Bug ID: 107601
Summary: Change SLOW_BYTE_ACCESS into
WIDEN_MODE_ACCESS_BITFIELD target hook
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Keywords: internal-improvement, missed-optimization
Severity: normal
Priority: P3
Component: middle-end
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Target Milestone: ---
This comes up every few years even. The name SLOW_BYTE_ACCESS and documentation
is confusing even and does not describe what it does.
I found that HJL proposed a decent naming target macro back in 2006 which I
will be using as a basis going forward.
HJL's patch
https://gcc.gnu.org/legacy-ml/gcc-patches/2006-09/msg00555.html
Wilco Dijkstra's patch which just removes SLOW_BYTE_ACCESS
https://gcc.gnu.org/legacy-ml/gcc-patches/2017-11/msg01547.html
This is part of my bit-field lowering work too.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107601] Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook
2022-11-10 1:04 [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook pinskia at gcc dot gnu.org
@ 2022-11-10 1:04 ` pinskia at gcc dot gnu.org
2022-11-10 1:36 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-10 1:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107601
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
Last reconfirmed| |2022-11-10
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107601] Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook
2022-11-10 1:04 [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook pinskia at gcc dot gnu.org
2022-11-10 1:04 ` [Bug middle-end/107601] " pinskia at gcc dot gnu.org
@ 2022-11-10 1:36 ` pinskia at gcc dot gnu.org
2022-11-10 7:37 ` rguenth at gcc dot gnu.org
2022-11-10 22:36 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-10 1:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107601
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note SLOW_SHORT_ACCESS is unused and has been as far as I can tell it was never
used.
I submitted a patch to remove it:
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/605574.html
Note also at one point SLOW_BYTE_ACCESS was used to control the size of bool
type in C++. This is even why on powerpc-darwin bool is 32bits ...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107601] Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook
2022-11-10 1:04 [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook pinskia at gcc dot gnu.org
2022-11-10 1:04 ` [Bug middle-end/107601] " pinskia at gcc dot gnu.org
2022-11-10 1:36 ` pinskia at gcc dot gnu.org
@ 2022-11-10 7:37 ` rguenth at gcc dot gnu.org
2022-11-10 22:36 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-11-10 7:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107601
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Related is probably STRICT_ALIGNMENT vs TARGET_SLOW_UNALIGNED_ACCESS
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107601] Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook
2022-11-10 1:04 [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2022-11-10 7:37 ` rguenth at gcc dot gnu.org
@ 2022-11-10 22:36 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-10 22:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107601
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #2)
> Related is probably STRICT_ALIGNMENT vs TARGET_SLOW_UNALIGNED_ACCESS
That one comes up every once in a while though less often though
STRICT_ALIGNMENT and TARGET_SLOW_UNALIGNED_ACCESS SHOULD have a well defined
meaning some folks misunderstand them. RS6000 target has a decent usage of them
really. Definitely Something which should be expanded on in the documentation
and made use it is used correctly in the middle-end but that is for a different
bug (which I am going to file).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-10 22:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 1:04 [Bug middle-end/107601] New: Change SLOW_BYTE_ACCESS into WIDEN_MODE_ACCESS_BITFIELD target hook pinskia at gcc dot gnu.org
2022-11-10 1:04 ` [Bug middle-end/107601] " pinskia at gcc dot gnu.org
2022-11-10 1:36 ` pinskia at gcc dot gnu.org
2022-11-10 7:37 ` rguenth at gcc dot gnu.org
2022-11-10 22:36 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).