[Bug target/107604] New: FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[Bug target/107604] New: FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

            Bug ID: 107604
           Summary: FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c
                    execution,  -O0  fails on aarch64_be
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ABI, testsuite-fail, wrong-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64_be-linux-gnu

FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -O0 
FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -O1 
FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -O2 
FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -O3 -g 
FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -Os 
FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution,  -Og -g 

My bet is there is mistmatch between the caller and callee; one side takes into
account big vs little endian shifting while the other side does not ...

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |clyon at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |clyon at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2022-11-10

--- Comment #1 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Sorry for the breakage, I'll have a look.

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

--- Comment #2 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Confirmed.
In test_dfp_17.c we have:
  ARG(_Decimal64, 11.0dd, D0)
  DOTS
  ANON(struct z, a, D1)
  ANON(struct z, b, STACK)
  ANON(int , 5, W0)
  ANON(_Decimal32, f1, STACK+32) /* Note: no promotion to _Decimal64.  */
  LAST_ANON(_Decimal64, 0.5dd, STACK+40)

Execution fails on aarch64_be for argument:
ANON(_Decimal32, f1, STACK+32)

in main() we generate:
str     s0, [sp, 32]    // 19   [c=4 l=4]  *movsd_aarch64/7 for aarch64
and
str     s0, [sp, 36]    // 19   [c=4 l=4]  *movsd_aarch64/7 for aarch64_be


Alignment for the last argument (_Decimal64) still seems OK, at sp+40.

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

--- Comment #3 from Christophe Lyon <clyon at gcc dot gnu.org> ---
and patching test_dfp_17.c like so:
-  ANON(_Decimal32, f1, STACK+32) /* Note: no promotion to _Decimal64.  */
+  ANON(_Decimal32, f1, STACK+36) /* Note: no promotion to _Decimal64.  */
makes it pass on aarch64_be

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:4eb3a48698b2ca43967a4e7e7cfc0408192e85b2

commit r13-4235-g4eb3a48698b2ca43967a4e7e7cfc0408192e85b2
Author: Christophe Lyon <christophe.lyon@arm.com>
Date:   Tue Nov 22 08:33:06 2022 +0000

    aarch64: Fix test_dfp_17.c for big-endian [PR 107604]

    gcc.target/aarch64/aapcs64/test_dfp_17.c has been failing on
    big-endian, because the _Decimal32 on-stack argument is not padded in
    the same direction depending on endianness.

    This patch fixes the testcase so that it expects the argument in the
    right stack location, similarly to what other tests do in the same
    directory.

    gcc/testsuite/ChangeLog:

            PR target/107604
            * gcc.target/aarch64/aapcs64/test_dfp_17.c: Fix for big-endian.

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Fixed.

[Bug target/107604] FAIL: gcc.target/aarch64/aapcs64/test_dfp_17.c execution, -O0 fails on aarch64_be

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107604

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Thanks for the fix by the way.