public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "xry111 at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/107608] [13 Regression] Failure on fold-overflow-1.c and pr95115.c
Date: Thu, 26 Jan 2023 14:29:21 +0000	[thread overview]
Message-ID: <bug-107608-4-SysJSbWRPS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107608-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107608

--- Comment #44 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
(In reply to rguenther@suse.de from comment #43)
> On Thu, 19 Jan 2023, xry111 at gcc dot gnu.org wrote:
> 
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107608
> > 
> > --- Comment #42 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
> > (In reply to Richard Biener from comment #41)
> > > We could fix the testcase with
> > > 
> > > diff --git a/gcc/testsuite/gcc.dg/pr95115.c b/gcc/testsuite/gcc.dg/pr95115.c
> > > index 69c4f83250c..09273e445d2 100644
> > > --- a/gcc/testsuite/gcc.dg/pr95115.c
> > > +++ b/gcc/testsuite/gcc.dg/pr95115.c
> > > @@ -17,6 +17,7 @@ int
> > >  main (void)
> > >  {
> > >    double r = x ();
> > > +  volatile double rr = r;
> > >    if (!__builtin_isnan (r))
> > >         abort ();
> > >    if (!fetestexcept (FE_INVALID))
> > > 
> > > that preserves optimizing the isnan check but also preserves the computation
> > > and checks the non-propagation of a NaN.
> > 
> > Hmm, so it means we cannot rely on Inf / Inf to raise an exception?  Then we
> > need to fix Glibc...
> 
> If the result is unused then no, GCC will happily elide exceptions from
> unused computations like Inexact from the statement
> 
>  1./3.;
> 
> but this has been done before.  What's new is that GCC can now elide
> some uses (in this case the isnan check is the only use)

The should we just change PR95115 to "INVALID" and remove the test case, and
fix any regression on Glibc side?

  parent reply	other threads:[~2023-01-26 14:29 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  9:47 [Bug tree-optimization/107608] New: [13 Regression] Failure on fold-overflow-1.c jakub at gcc dot gnu.org
2022-11-10  9:49 ` [Bug tree-optimization/107608] " jakub at gcc dot gnu.org
2022-11-10 13:47 ` rguenth at gcc dot gnu.org
2022-11-10 18:13 ` pinskia at gcc dot gnu.org
2022-11-11  7:18 ` pinskia at gcc dot gnu.org
2022-11-13  6:30 ` [Bug tree-optimization/107608] [13 Regression] Failure on fold-overflow-1.c and pr95115.c xry111 at gcc dot gnu.org
2022-11-28 10:06 ` rguenth at gcc dot gnu.org
2022-12-05 13:22 ` aldyh at gcc dot gnu.org
2022-12-05 15:14 ` rguenth at gcc dot gnu.org
2022-12-05 16:30 ` aldyh at gcc dot gnu.org
2022-12-16 13:20 ` jakub at gcc dot gnu.org
2022-12-16 13:32 ` rguenth at gcc dot gnu.org
2023-01-09 15:18 ` aldyh at gcc dot gnu.org
2023-01-10  8:56 ` rguenth at gcc dot gnu.org
2023-01-10  8:58 ` rguenth at gcc dot gnu.org
2023-01-10 10:20 ` aldyh at gcc dot gnu.org
2023-01-10 10:25 ` aldyh at gcc dot gnu.org
2023-01-10 11:00 ` rguenth at gcc dot gnu.org
2023-01-10 11:09 ` jakub at gcc dot gnu.org
2023-01-10 12:08 ` rguenther at suse dot de
2023-01-10 14:14 ` jakub at gcc dot gnu.org
2023-01-10 14:25 ` amacleod at redhat dot com
2023-01-10 14:33 ` aldyh at gcc dot gnu.org
2023-01-10 14:39 ` jakub at gcc dot gnu.org
2023-01-10 14:40 ` aldyh at gcc dot gnu.org
2023-01-10 14:42 ` jakub at gcc dot gnu.org
2023-01-12 11:42 ` aldyh at gcc dot gnu.org
2023-01-12 12:03 ` jakub at gcc dot gnu.org
2023-01-12 12:26 ` xry111 at gcc dot gnu.org
2023-01-13 13:19 ` aldyh at gcc dot gnu.org
2023-01-13 13:25 ` aldyh at gcc dot gnu.org
2023-01-15 15:43 ` cvs-commit at gcc dot gnu.org
2023-01-16 21:38 ` romain.geissler at amadeus dot com
2023-01-16 21:46 ` jakub at gcc dot gnu.org
2023-01-16 21:55 ` romain.geissler at amadeus dot com
2023-01-16 21:58 ` fw at gcc dot gnu.org
2023-01-18 12:26 ` aldyh at gcc dot gnu.org
2023-01-18 12:54 ` jakub at gcc dot gnu.org
2023-01-18 12:56 ` aldyh at gcc dot gnu.org
2023-01-18 13:00 ` rguenth at gcc dot gnu.org
2023-01-18 13:03 ` rguenth at gcc dot gnu.org
2023-01-18 13:05 ` rguenth at gcc dot gnu.org
2023-01-19  1:15 ` xry111 at gcc dot gnu.org
2023-01-19  7:17 ` rguenther at suse dot de
2023-01-26 14:29 ` xry111 at gcc dot gnu.org [this message]
2023-01-27  7:35 ` rguenth at gcc dot gnu.org
2023-01-27  7:59 ` xry111 at gcc dot gnu.org
2023-01-27  9:53 ` rguenther at suse dot de
2023-01-27 10:02 ` xry111 at gcc dot gnu.org
2023-01-27 10:13 ` jakub at gcc dot gnu.org
2023-01-27 11:30 ` rguenther at suse dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107608-4-SysJSbWRPS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).