[Bug middle-end/107618] Incorrect diagnostics when using -Og, builtin_expect(), and function attribute "warning" or "error"

["yann at droneaud dot fr" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107618

--- Comment #2 from Yann Droneaud <yann at droneaud dot fr> ---
I was wondering what GCC expects __builtin_object_size(0, 0) to be, and used
the following:

    void a_1 (void) __attribute__((__warning__("-1")));
    void a0 (void) __attribute__((__warning__("0")));
    void a1 (void) __attribute__((__warning__("1")));
    void a2 (void) __attribute__((__warning__("2")));
    void a3 (void) __attribute__((__warning__("3")));
    void a4 (void) __attribute__((__warning__("4")));

    int main(void) {
      unsigned long b = __builtin_object_size(0, 0);
      if (__builtin_expect(b == (unsigned long)-1, 0))
        a_1();
      if (__builtin_expect(b == 0, 0))
        a0();
      if (__builtin_expect(b == 1, 0))
        a1();
      if (__builtin_expect(b == 2, 0))
        a2();
      if (__builtin_expect(b == 3, 0))
        a3();
      if (__builtin_expect(b == 4, 0))
        a4();
    }

It works as expected for any level above 0, except -Og:

    $ gcc -O1 -S warning.c
    warning.c: In function ‘main’:
    warning.c:11:5: warning: call to ‘a_1’ declared with attribute warning: -1
[-Wattribute-warning]
       11 |     a_1();
          |     ^~~~~

It's quite reassuring that __builtin_object_size(0, 0) returns -1, hence the
emitted call to a_1():

    $ cat warning.s
            .file        "warning.c"
            .text
            .globl        main
            .type        main, @function
    main:
            endbr64
            subq        $8, %rsp
            call        a_1@PLT
            movl        $0, %eax
            addq        $8, %rsp
            ret

For -Og, there's a firework of warnings (shockingly they're the same than -O0
level):

    $ gcc -Og -S warning.c
    warning.c: In function ‘main’:
    warning.c:11:5: warning: call to ‘a_1’ declared with attribute warning: -1
[-Wattribute-warning]
       11 |     a_1();
          |     ^~~~~
    warning.c:13:5: warning: call to ‘a0’ declared with attribute warning: 0
[-Wattribute-warning]
       13 |     a0();
          |     ^~~~
    warning.c:15:5: warning: call to ‘a1’ declared with attribute warning: 1
[-Wattribute-warning]
       15 |     a1();
          |     ^~~~
    warning.c:17:5: warning: call to ‘a2’ declared with attribute warning: 2
[-Wattribute-warning]
       17 |     a2();
          |     ^~~~
    warning.c:19:5: warning: call to ‘a3’ declared with attribute warning: 3
[-Wattribute-warning]
       19 |     a3();
          |     ^~~~
    warning.c:21:5: warning: call to ‘a4’ declared with attribute warning: 4
[-Wattribute-warning]
       21 |     a4();
          |     ^~~~

Generated assembly for -Og is the same than for levels above 0: a call to a_1()
function is emitted, which mean GCC, at some point, knows
__builtin_object_size(0, 0) is -1 here. Thus most of the warnings are not very
useful.

    $ cat warning.s
            .file        "warning.c"
            .text
            .globl        main
            .type        main, @function
    main:
            endbr64
            subq        $8, %rsp
            call        a_1@PLT
            movl        $0, %eax
            addq        $8, %rsp
            ret