public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "yann at droneaud dot fr" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/107618] New: Incorrect diagnostics when using -Og, builtin_expect(), and function attribute "warning" or "error" Date: Thu, 10 Nov 2022 15:42:40 +0000 [thread overview] Message-ID: <bug-107618-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107618 Bug ID: 107618 Summary: Incorrect diagnostics when using -Og, builtin_expect(), and function attribute "warning" or "error" Product: gcc Version: unknown Status: UNCONFIRMED Severity: normal Priority: P3 Component: other Assignee: unassigned at gcc dot gnu.org Reporter: yann at droneaud dot fr Target Milestone: --- Created attachment 53872 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53872&action=edit reproducer for -Og, __builtin_expect(), and function __attribute__((warning(""))) The code below compiled with -Og triggers a warning message that is not mandated: $ gcc -Og warning.c warning.c: In function ‘test_expect’: warning.c:26:17: warning: call to ‘size_mismatch_expect’ declared with attribute warning: size mismatch (builtin_expect) [-Wattribute-warning] 26 | size_mismatch_expect(); | ^~~~~~~~~~~~~~~~~~~~~~ $ cat warning.c #include <stdbool.h> #include <stddef.h> #include <stdlib.h> extern void size_mismatch_nonexpect(void) __attribute__((__warning__("size mismatch"))); static bool test_nonexpect(const void *addr, size_t len) { size_t sz = __builtin_object_size(addr, 0); if (sz != (size_t)-1 && sz < len) { size_mismatch_nonexpect(); return false; } return true; } extern void size_mismatch_expect(void) __attribute__((__warning__("size mismatch (builtin_expect)"))); static bool test_expect(const void *addr, size_t len) { size_t sz = __builtin_object_size(addr, 0); if (__builtin_expect(sz != (size_t)-1 && sz < len, 0)) { size_mismatch_expect(); return false; } return true; } int main(void) { int i = 0; if (!test_nonexpect(&i, sizeof(i))) return EXIT_FAILURE; if (!test_expect(&i, sizeof(i))) return EXIT_FAILURE; return EXIT_SUCCESS; } The warning at -Og level is not expected because there's no call to the size_mismatch_expect() in the generated assembler (for x86-64): $ head warning.s .file "warning.c" .text .type test_nonexpect, @function test_nonexpect: movl $1, %eax ret .size test_nonexpect, .-test_nonexpect .type test_expect, @function test_expect: movl $1, %eax ret .size test_expect, .-test_expect .globl main .type main, @function main: endbr64 subq $24, %rsp movq %fs:40, %rax movq %rax, 8(%rsp) xorl %eax, %eax movl $0, 4(%rsp) leaq 4(%rsp), %rdi movl $4, %esi call test_nonexpect testb %al, %al jne .L11 movl $1, %eax .L5: movq 8(%rsp), %rdx subq %fs:40, %rdx jne .L12 addq $24, %rsp ret .L11: leaq 4(%rsp), %rdi movl $4, %esi call test_expect testb %al, %al je .L9 movl $0, %eax jmp .L5 .L9: movl $1, %eax jmp .L5 See also https://godbolt.org/z/KEsaavhvG Compiling at optimization level s, z, 1, 2, or 3 doesn't produce that warning. (but compiling with -O0 does produces two warnings, as expected, since calls to the two functions are emitted). Having the warning at debug optimization level makes using -Og in some complex code base challenging for no good reason when __attribute__((error(""))) is used (or -Werror=attribute-warning). It should also be noted clang doesn't generate the warning for optimization level above 0.
next reply other threads:[~2022-11-10 15:42 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-10 15:42 yann at droneaud dot fr [this message] 2022-11-10 17:21 ` [Bug middle-end/107618] " yann at droneaud dot fr 2022-11-10 17:45 ` yann at droneaud dot fr 2022-11-11 7:47 ` [Bug tree-optimization/107618] " rguenth at gcc dot gnu.org 2022-11-11 13:32 ` cvs-commit at gcc dot gnu.org 2022-11-11 13:33 ` rguenth at gcc dot gnu.org 2022-11-11 14:37 ` yann at droneaud dot fr 2022-11-28 22:19 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107618-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).