[Bug libgomp/107641] New: libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[Bug libgomp/107641] New: libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107641

            Bug ID: 107641
           Summary: libgomp/env.c:286:20: error: cast from pointer to
                    integer of different size
                    [-Werror=pointer-to-int-cast]
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: redi at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---

I'm seeing a bootstrap failure on mingw-w64

../../../gcc/libgomp/env.c: In function 'parse_unsigned_long':
../../../gcc/libgomp/env.c:286:20: error: cast from pointer to integer of
different size [-Werror=pointer-to-int-cast]
  286 |   unsigned upper = (unsigned long) params[2];
      |                    ^
cc1: all warnings being treated as errors

unsigned long is 32-bit on Windows.

[Bug libgomp/107641] [13 Regression] libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107641

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel at codesourcery dot com
             Target|                            |*mingw*
      Known to fail|                            |13.0
            Summary|libgomp/env.c:286:20:       |[13 Regression]
                   |error: cast from pointer to |libgomp/env.c:286:20:
                   |integer of different size   |error: cast from pointer to
                   |[-Werror=pointer-to-int-cas |integer of different size
                   |t]                          |[-Werror=pointer-to-int-cas
                   |                            |t]
      Known to work|                            |12.2.0
   Target Milestone|---                         |13.0

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Presumably started with r13-2545-g9f2fca56593a2b

[Bug libgomp/107641] [13 Regression] libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107641

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
   Last reconfirmed|                            |2022-11-11
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 53885
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53885&action=edit
gcc13-pr107641.patch

Untested fix.
Using unsigned for upper is also quite suspicious, because the code then does
if (upper <= UCHAR_MAX)
something;
else if (upper <= UINT_MAX)
something else;
else
something different;
but if upper is unsigned, then upper <= UINT_MAX is always true.

[Bug libgomp/107641] [13 Regression] libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107641

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2a193e9df82917eaf440a20f99a3febe91dcb5fe

commit r13-3927-g2a193e9df82917eaf440a20f99a3febe91dcb5fe
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Nov 12 09:47:50 2022 +0100

    libgomp: Fix up build on mingw [PR107641]

    Pointers should be first casted to intptr_t/uintptr_t before casting
    them to another integral type to avoid warnings.
    Furthermore, the function has code like
      else if (upper <= UINT_MAX)
        something;
      else
        something_else;
    so it seems using unsigned type for upper where upper <= UINT_MAX is always
    true is not intended.

    2022-11-12  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/107641
            * env.c (parse_unsigned_long): Cast params[2] to uintptr_t rather
than
            unsigned long.  Change type of upper from unsigned to unsigned
long.

[Bug libgomp/107641] [13 Regression] libgomp/env.c:286:20: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107641

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.