public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/107692] [13 regression] r13-3950-g071e428c24ee8c breaks many test cases
Date: Thu, 24 Nov 2022 01:20:45 +0000	[thread overview]
Message-ID: <bug-107692-4-YHTm48c8dQ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107692-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107692

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hongyu Wang <hongyuw@gcc.gnu.org>:

https://gcc.gnu.org/g:8caf155a3d6e23e47bf55068ad23c23d4655a054

commit r13-4272-g8caf155a3d6e23e47bf55068ad23c23d4655a054
Author: Hongyu Wang <hongyu.wang@intel.com>
Date:   Sat Nov 19 09:38:00 2022 +0800

    i386: Only enable small loop unrolling in backend [PR 107692]

    Followed by the discussion in pr107692, -munroll-only-small-loops
    Does not turns on/off -funroll-loops, and current check in
    pass_rtl_unroll_loops::gate would cause -fno-unroll-loops do not take
    effect. Revert the change about targetm.loop_unroll_adjust and apply
    the backend option change to strictly follow the rule that
    -funroll-loops takes full control of loop unrolling, and
    munroll-only-small-loops just change its behavior to unroll small size
    loops.

    gcc/ChangeLog:

            PR target/107692
            * common/config/i386/i386-common.cc (ix86_optimization_table):
            Enable loop unroll O2, disable -fweb and -frename-registers
            by default.
            * config/i386/i386-options.cc
            (ix86_override_options_after_change):
            Disable small loop unroll when funroll-loops enabled, reset
            cunroll_grow_size when it is not explicitly enabled.
            (ix86_option_override_internal): Call
            ix86_override_options_after_change instead of calling
            ix86_recompute_optlev_based_flags and ix86_default_align
            separately.
            * config/i386/i386.cc (ix86_loop_unroll_adjust): Adjust unroll
            factor if -munroll-only-small-loops enabled.
            * loop-init.cc (pass_rtl_unroll_loops::gate): Do not enable
            loop unrolling for -O2-speed.
            (pass_rtl_unroll_loops::execute): Rmove
            targetm.loop_unroll_adjust check.

    gcc/testsuite/ChangeLog:

            PR target/107692
            * gcc.dg/guality/loop-1.c: Remove additional option for ia32.
            * gcc.target/i386/pr86270.c: Add -fno-unroll-loops.
            * gcc.target/i386/pr93002.c: Likewise.

  parent reply	other threads:[~2022-11-24  1:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 21:20 [Bug target/107692] New: " seurer at gcc dot gnu.org
2022-11-14 21:51 ` [Bug target/107692] " pinskia at gcc dot gnu.org
2022-11-15  5:33 ` pinskia at gcc dot gnu.org
2022-11-15  7:02 ` wwwhhhyyy333 at gmail dot com
2022-11-15 11:49 ` segher at gcc dot gnu.org
2022-11-16 13:19 ` rguenth at gcc dot gnu.org
2022-11-18  6:11 ` guojiufu at gcc dot gnu.org
2022-11-18  6:13 ` guojiufu at gcc dot gnu.org
2022-11-18  7:07 ` wwwhhhyyy333 at gmail dot com
2022-11-18 13:35 ` guojiufu at gcc dot gnu.org
2022-11-18 14:11 ` segher at gcc dot gnu.org
2022-11-18 14:12 ` segher at gcc dot gnu.org
2022-11-18 19:37 ` wwwhhhyyy333 at gmail dot com
2022-11-18 21:44 ` segher at gcc dot gnu.org
2022-11-24  1:20 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-24  1:22 ` wwwhhhyyy333 at gmail dot com
2022-12-19 22:53 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107692-4-YHTm48c8dQ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).