[Bug fortran/107707] New: ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[Bug fortran/107707] New: ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

            Bug ID: 107707
           Summary: ICE in gfc_compare_actual_formal, at
                    fortran/interface.cc:3284
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   character(3), allocatable :: c
   c = 'abc'
   call s(c)
contains
   subroutine s(x)
      character(real(3)), allocatable :: x
   end
end


$ gfortran-13-20221106 -c z1.f90
z1.f90:7:16:

    7 |       character(real(3)), allocatable :: x
      |                1
Error: Expression at (1) must be of INTEGER type, found REAL
f951: internal compiler error: Segmentation fault
0xf4697f crash_signal
        ../../gcc/toplev.cc:314
0x80de4a gfc_compare_actual_formal(gfc_actual_arglist**, gfc_formal_arglist*,
int, int, bool, locus*)
        ../../gcc/fortran/interface.cc:3284
0x80e5e6 gfc_procedure_use(gfc_symbol*, gfc_actual_arglist**, locus*)
        ../../gcc/fortran/interface.cc:4167
0x87ad0a resolve_specific_s0
        ../../gcc/fortran/resolve.cc:3636
0x87ad0a resolve_specific_s
        ../../gcc/fortran/resolve.cc:3656
0x87ad0a resolve_call
        ../../gcc/fortran/resolve.cc:3810
0x87839f gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.cc:12231
0x87a387 resolve_codes
        ../../gcc/fortran/resolve.cc:17624
0x87a44e gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.cc:17659
0x862214 resolve_all_program_units
        ../../gcc/fortran/parse.cc:6631
0x862214 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6887
0x8b0c8f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |kargl at gcc dot gnu.org
   Last reconfirmed|                            |2022-11-15
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from kargl at gcc dot gnu.org ---
Another example of why -fmax-errors=1 should be the default.

A run-on warning triggers tried to get a gmp value from a BT_REAL entity.

Fixed by

diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc
index d3e199535b3..ce68d863fdf 100644
--- a/gcc/fortran/interface.cc
+++ b/gcc/fortran/interface.cc
@@ -3271,10 +3271,14 @@ gfc_compare_actual_formal (gfc_actual_arglist **ap,
gfc_formal_arglist *formal,
         and assumed-shape dummies, the string length needs to match
         exactly.  */
       if (a->expr->ts.type == BT_CHARACTER
-         && a->expr->ts.u.cl && a->expr->ts.u.cl->length
+         && a->expr->ts.u.cl
+         && a->expr->ts.u.cl->length
+         && a->expr->ts.u.cl->length->ts.type == BT_INTEGER
          && a->expr->ts.u.cl->length->expr_type == EXPR_CONSTANT
-         && f->sym->ts.type == BT_CHARACTER && f->sym->ts.u.cl
+         && f->sym->ts.type == BT_CHARACTER
+         && f->sym->ts.u.cl
          && f->sym->ts.u.cl->length
+         && f->sym->ts.u.cl->length->ts.type == BT_INTEGER
          && f->sym->ts.u.cl->length->expr_type == EXPR_CONSTANT
          && (f->sym->attr.pointer || f->sym->attr.allocatable
              || (f->sym->as && f->sym->as->type == AS_ASSUMED_SHAPE))

[Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
(In reply to kargl from comment #1)
> Fixed by
> 
> diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc

Simple and obvious.

If you don't object, I can commit it for you.

[Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

--- Comment #3 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Wed, Nov 16, 2022 at 09:16:17PM +0000, anlauf at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707
> 
> anlauf at gcc dot gnu.org changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |anlauf at gcc dot gnu.org
> 
> --- Comment #2 from anlauf at gcc dot gnu.org ---
> (In reply to kargl from comment #1)
> > Fixed by
> > 
> > diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc
> 
> Simple and obvious.
> 
> If you don't object, I can commit it for you.
> 

Unfortunately, committing patches requires knowledge
of git and going through some prelim setting up of 
an environment.

[Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:bdd784fc48a283d54f5f1e3cc2a0668c14dd3bee

commit r13-4113-gbdd784fc48a283d54f5f1e3cc2a0668c14dd3bee
Author: Steve Kargl <kargl@gcc.gnu.org>
Date:   Wed Nov 16 22:46:55 2022 +0100

    Fortran: ICE on procedure arguments with non-integer length [PR107707]

    gcc/fortran/ChangeLog:

            PR fortran/107707
            * interface.cc (gfc_compare_actual_formal): Check that we actually
            have integer values before asking gmp_* to use them.

    gcc/testsuite/ChangeLog:

            PR fortran/107707
            * gfortran.dg/pr107707.f90: New test.

[Bug fortran/107707] ICE in gfc_compare_actual_formal, at fortran/interface.cc:3284

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107707

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |13.0

--- Comment #5 from kargl at gcc dot gnu.org ---
(In reply to CVS Commits from comment #4)
> The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
> 
> https://gcc.gnu.org/g:bdd784fc48a283d54f5f1e3cc2a0668c14dd3bee
> 
> commit r13-4113-gbdd784fc48a283d54f5f1e3cc2a0668c14dd3bee
> Author: Steve Kargl <kargl@gcc.gnu.org>
> Date:   Wed Nov 16 22:46:55 2022 +0100
> 
>     Fortran: ICE on procedure arguments with non-integer length [PR107707]
>     
>     gcc/fortran/ChangeLog:
>     
>             PR fortran/107707
>             * interface.cc (gfc_compare_actual_formal): Check that we
> actually
>             have integer values before asking gmp_* to use them.
>     
>     gcc/testsuite/ChangeLog:
>     
>             PR fortran/107707
>             * gfortran.dg/pr107707.f90: New test.

Thanks Harald.  Closing.