public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr
@ 2022-11-17 19:29 pinskia at gcc dot gnu.org
2022-11-17 23:49 ` [Bug middle-end/107737] " pinskia at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-17 19:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107737
Bug ID: 107737
Summary: seemly looking off code in gimplify_call_expr
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: middle-end
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Target Milestone: ---
The code has:
```
location_t loc = EXPR_LOCATION (*expr_p);
gcc_assert (TREE_CODE (*expr_p) == CALL_EXPR);
/* For reliable diagnostics during inlining, it is necessary that
every call_expr be annotated with file and line. */
if (! EXPR_HAS_LOCATION (*expr_p))
SET_EXPR_LOCATION (*expr_p, input_location);
....
USE(loc) below
```
This seems wrong for the location.
I don't know if the SET_EXPR_LOCATION is dead code or not but this does seem
wrong.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107737] seemly looking off code in gimplify_call_expr
2022-11-17 19:29 [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr pinskia at gcc dot gnu.org
@ 2022-11-17 23:49 ` pinskia at gcc dot gnu.org
2022-11-17 23:49 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-17 23:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107737
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
See Also| |https://gcc.gnu.org/bugzill
| |a/show_bug.cgi?id=40435
Last reconfirmed| |2022-11-17
Keywords| |internal-improvement
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
r0-94701-gdb3927fb49c9 (for PR 40435) added the "loc = EXPR_LOCATION
(*expr_p);" before setting of the location.
The original code of gimplify_call_expr (when it was merged in from the
tree-ssa branch) had the setting of the location if it was not set.
I think for GCC 14, I am going to try to see if setting of the location is
really still needed (that is going to change it to an assert and run a full
bootstrap/test including Ada).
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107737] seemly looking off code in gimplify_call_expr
2022-11-17 19:29 [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr pinskia at gcc dot gnu.org
2022-11-17 23:49 ` [Bug middle-end/107737] " pinskia at gcc dot gnu.org
@ 2022-11-17 23:49 ` pinskia at gcc dot gnu.org
2023-07-23 0:34 ` pinskia at gcc dot gnu.org
2023-07-23 2:07 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-17 23:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107737
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107737] seemly looking off code in gimplify_call_expr
2022-11-17 19:29 [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr pinskia at gcc dot gnu.org
2022-11-17 23:49 ` [Bug middle-end/107737] " pinskia at gcc dot gnu.org
2022-11-17 23:49 ` pinskia at gcc dot gnu.org
@ 2023-07-23 0:34 ` pinskia at gcc dot gnu.org
2023-07-23 2:07 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-23 0:34 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107737
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So far gimplify_vla_decl does not set the location on the call expression it
creates. It should be set to the same as the decl source location.
Testing that ...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug middle-end/107737] seemly looking off code in gimplify_call_expr
2022-11-17 19:29 [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2023-07-23 0:34 ` pinskia at gcc dot gnu.org
@ 2023-07-23 2:07 ` pinskia at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-07-23 2:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107737
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
A C++ front-end does not set the call for deconstructor for the following
testcase:
```
struct s{ ~s(); };
void f()
{
s{};
}
```
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-23 2:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 19:29 [Bug middle-end/107737] New: seemly looking off code in gimplify_call_expr pinskia at gcc dot gnu.org
2022-11-17 23:49 ` [Bug middle-end/107737] " pinskia at gcc dot gnu.org
2022-11-17 23:49 ` pinskia at gcc dot gnu.org
2023-07-23 0:34 ` pinskia at gcc dot gnu.org
2023-07-23 2:07 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).