[Bug analyzer/107750] New: Many gcc.dg/analyzer/fd-*.c tests FAIL

[Bug analyzer/107750] New: Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

            Bug ID: 107750
           Summary: Many gcc.dg/analyzer/fd-*.c tests FAIL
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11, powerpc-ibm-aix7.2.5.0,
                    pru-unknown-elf, x86_64-unknown-freebsd12.4

Since 20221116, many of the new gcc.dg/analyzer/fd-*.c tests FAIL.  I'm seeing
this on Solaris (both SPARC and x86, 32 and 64-bit), but there are also reports
for AIX, FreeBSD/x86_64, and others.

In the Solaris case, there's

+FAIL: gcc.dg/analyzer/fd-accept.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:54:3:
warning: 'accept' on file descriptor 'fd' in wrong phase
[-Wanalyzer-fd-phase-mismatch]

+FAIL: gcc.dg/analyzer/fd-accept.c final event at line 55 (test for warnings,
line 54)
+FAIL: gcc.dg/analyzer/fd-accept.c warning (test for warnings, line 54)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 17)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 25)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 30)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 37)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 53)
+FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c (test for excess errors)
+FAIL: gcc.dg/analyzer/fd-bind.c  (test for warnings, line 24)
+FAIL: gcc.dg/analyzer/fd-bind.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:10:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:10:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:12:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:12:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:30:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:32:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:52:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:54:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:67:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:69:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-bind.c:24:3:
warning: UNKNOWN

+FAIL: gcc.dg/analyzer/fd-connect.c  (test for warnings, line 18)
+FAIL: gcc.dg/analyzer/fd-connect.c  (test for warnings, line 32)
+FAIL: gcc.dg/analyzer/fd-connect.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-connect.c:18:3:
warning: UNKNOWN

+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 28)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 34)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 46)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 68)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 79)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 82)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 9)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 90)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 94)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:47:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:47:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:49:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:49:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:58:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:60:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:71:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:73:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:97:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:99:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:28:3:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:46:3:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:82:3:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:94:3:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-datagram-socket.c:83:3:
warning: 'listen' on file descriptor 'fd' in wrong phase
[-Wanalyzer-fd-phase-mismatch]

+FAIL: gcc.dg/analyzer/fd-datagram-socket.c final event at line 106 (test for
warnings, line 105)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c final event at line 84 (test for
war
nings, line 83)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c warning (test for warnings, line
105)
+FAIL: gcc.dg/analyzer/fd-datagram-socket.c warning (test for warnings, line
83)
+FAIL: gcc.dg/analyzer/fd-listen.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:26:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:26:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:28:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:28:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:36:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:38:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-listen.c:50:3:
warning: 'listen' on file descriptor 'fd' in wrong phase
[-Wanalyzer-fd-phase-mismatch]

+FAIL: gcc.dg/analyzer/fd-listen.c final event at line 51 (test for warnings,
line 50)
+FAIL: gcc.dg/analyzer/fd-listen.c warning (test for warnings, line 50)
+FAIL: gcc.dg/analyzer/fd-socket-misuse.c  (test for warnings, line 14)
+FAIL: gcc.dg/analyzer/fd-socket-misuse.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:25:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:25:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:27:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:27:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:49:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:51:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:93:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:95:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-socket-misuse.c:17:3:
warning: 'read' on possibly invalid file descriptor 'fd'
[-Wanalyzer-fd-use-without-check]

+FAIL: gcc.dg/analyzer/fd-socket-misuse.c final event at line 18 (test for
warnings, line 17)
+FAIL: gcc.dg/analyzer/fd-socket-misuse.c warning (test for warnings, line 17)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
14)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
17)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
28)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
29)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line 
35)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
43)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
59)
+FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:21:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:21:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:23:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:23:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:51:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:53:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:14:7:
warning: UNKNOWN
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:17:3:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:28:7:
warning: state: 'fd-new-unknown-socket'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:29:7:
warning: UNKNOWN
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:35:3:
warning: state: 'fd-stop'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:43:3:
warning: state: 'fd-stop'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:43:3:
warning: state: 'fd-stop'
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket-active-open.c:59:7:
warning: UNKNOWN

+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 110)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 138)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 150)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 179)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 20)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 23)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 31)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line
 32)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 37)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 42)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 43)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 55)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 87)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings,
line 98)
+FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c (test for excess errors)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 33)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 66)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 77)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 88)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 9)
+FAIL: gcc.dg/analyzer/fd-stream-socket.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:45:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:45:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:47:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:47:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:56:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:58:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:69:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:71:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:91:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-stream-socket.c:93:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]

+FAIL: gcc.dg/analyzer/fd-symbolic-socket.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:45:3:
warning: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:45:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:47:3:
warning: implicit declaration of function 'strncpy'
[-Wimplicit-function-declaration]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:47:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:56:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:58:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:69:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:71:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:91:3:
warning: incompatible implicit declaration of built-in function 'memset'
[-Wbuiltin-declaration-mismatch]
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-symbolic-socket.c:93:3:
warning: incompatible implicit declaration of built-in function 'strncpy'
[-Wbuiltin-declaration-mismatch]

  32 and 64-bit sparc and x86

One part of the excess errors can be fixed by including <string.h> for memset
and strncpy declarations (patch attached).  However, even with that change,
an enormous number of failures remains.  It feels like there's something
Linux-specific in there.

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 53925
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53925&action=edit
Patch for missing <string.h> includes

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2022-11-18

--- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Sorry about the breakage; thanks for filing this, and for the patch.

Looking at:
  FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
line 53)
it looks like the analyzer was able to figure out the values of O_RDONLY and
O_WRONLY in your headers, but not of O_ACCMODE.  I suspect it might be having
issues with SOCK_STREAM and SOCK_DGRAM also.

How are these values defined in your headers?  The analyzer has gained some
ability to try to e.g. scrape macro values from the C frontend, but only some
cases are supported.

There's a way of debugging this using -fdump-analyzer, but I'm looking at
adding a way to make such issues show up more clearly in the DejaGnu logs,
which hopefully should make them easier to track down.

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #3 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #2 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
> Sorry about the breakage; thanks for filing this, and for the patch.
>
> Looking at:
>   FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings,
> line 53)
> it looks like the analyzer was able to figure out the values of O_RDONLY and
> O_WRONLY in your headers, but not of O_ACCMODE.  I suspect it might be having
> issues with SOCK_STREAM and SOCK_DGRAM also.
>
> How are these values defined in your headers?  The analyzer has gained some
> ability to try to e.g. scrape macro values from the C frontend, but only some
> cases are supported.

<sys/fcntl.h>:

#define O_ACCMODE       (O_SEARCH | O_EXEC | 0x3)

<sys/socket.h>:          

#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
#define SOCK_STREAM     NC_TPI_COTS     /* stream socket */
#define SOCK_DGRAM      NC_TPI_CLTS     /* datagram socket */
#define SOCK_RAW        NC_TPI_RAW      /* raw-protocol interface */
#else
#define SOCK_STREAM     2               /* stream socket */
#define SOCK_DGRAM      1               /* datagram socket */
#define SOCK_RAW        4               /* raw-protocol interface */
#endif  /* !defined(_XPG4_2) || defined(__EXTENSIONS__) */

NC_TPI_COTS is also 2, same for the other two.

> There's a way of debugging this using -fdump-analyzer, but I'm looking at
> adding a way to make such issues show up more clearly in the DejaGnu logs,
> which hopefully should make them easier to track down.

That would certainly be nice.

Thanks.
        Rainer

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.0                        |13.2

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.1 is being released, retargeting bugs to GCC 13.2.

[Bug analyzer/107750] Many gcc.dg/analyzer/fd-*.c tests FAIL

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.2                        |13.3

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.2 is being released, retargeting bugs to GCC 13.3.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
David, after your amazing work on PR analyzer/111475, there are only a handful
of analyzer failures left on trunk:

FAIL: gcc.dg/analyzer/fd-accept.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-accept.c final event at line 58 (test for warnings,
line 57)
FAIL: gcc.dg/analyzer/fd-accept.c warning (test for warnings, line 57)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
19)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
27)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
32)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
39)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
55)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-connect.c  (test for warnings, line 35)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 13)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 32)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 38)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 50)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 72)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 83)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 86)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 94)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c  (test for warnings, line 98)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c final event at line 110 (test for
warnings, line 109)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c final event at line 88 (test for
warnings, line 87)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c warning (test for warnings, line
109)
FAIL: gcc.dg/analyzer/fd-datagram-socket.c warning (test for warnings, line 87)
FAIL: gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c (test for excess
errors)
FAIL: gcc.dg/analyzer/fd-listen.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-listen.c final event at line 55 (test for warnings,
line 54)
FAIL: gcc.dg/analyzer/fd-listen.c warning (test for warnings, line 54)
FAIL: gcc.dg/analyzer/fd-socket-misuse.c  (test for warnings, line 18)
FAIL: gcc.dg/analyzer/fd-socket-misuse.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-socket-misuse.c final event at line 22 (test for
warnings, line 21)
FAIL: gcc.dg/analyzer/fd-socket-misuse.c warning (test for warnings, line 21)
FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
21)
FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
32)
FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
39)
FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c  (test for warnings, line
47)
FAIL: gcc.dg/analyzer/fd-stream-socket-active-open.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings, line
27)
FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings, line
35)
FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings, line
41)
FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c  (test for warnings, line
46)
FAIL: gcc.dg/analyzer/fd-stream-socket-passive-open.c (test for excess errors)
FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 13)
FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 37)
FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 70)
FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 81)
FAIL: gcc.dg/analyzer/fd-stream-socket.c  (test for warnings, line 92)

As an example, I looked into fd-accept.c, which shows those differences between
Linux and Solaris output:

--- /homes/ro/fd-accept.out.i.linux     2024-05-08 13:19:07.595246605 +0200
+++ fd-accept.out.i     2024-05-08 13:23:30.986283368 +0200
@@ -23,2 +23,2 @@
-/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:57:3:
warning: ‘accept’ on datagram socket file descriptor ‘fd’
[-Wanalyzer-fd-type-mismatch]
-/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:54:12:
note: (1) datagram socket created here
+/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:57:3:
warning: ‘accept’ on file descriptor ‘fd’ in wrong phase [CWE-666]
[-Wanalyzer-fd-phase-mismatch]
+/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:54:12:
note: (1) socket created here
@@ -28 +28 @@
-/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:57:3:
note: (5) ‘accept’ expects a stream socket file descriptor but ‘fd’ is a
datagram socket
+/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-accept.c:57:3:
note: (5) ‘accept’ expects a listening stream socket file descriptor but ‘fd’
has not yet been bound

Obviously the analyzer couldn't determine that fd is a datagram socket in
test_accept_on_new_datagram_socket.

However, if I compile the preprocessed Linux fd-accept.i on Solaris, I get
the same output as on Linux.

While Linux <x86_64-linux-gnu/bits/socket_type.h> has

enum __socket_type
{
  SOCK_STREAM = 1,              /* Sequenced, reliable, connection-based
                                   byte streams.  */
#define SOCK_STREAM SOCK_STREAM
  SOCK_DGRAM = 2,               /* Connectionless, unreliable datagrams
                                   of fixed maximum length.  */
#define SOCK_DGRAM SOCK_DGRAM

Solaris <sys/socket.h> has plain #define's instead:

#define SOCK_STREAM     2               /* stream socket */
#define SOCK_DGRAM      1               /* datagram socket */

As yo suspected in Comment #2, the analyzer seems unable to handle that yet.

As an experiment, I hacked the SOCK_STREAM and SOCK_DGRAM definitions in
fd-accept.i on Solaris
to also use an enum instead, the test now produces the same output as on Linux.

I also had a quick look into AIX 7.2 <sys/socket.h> and found it also uses
#define's for the SOCK_* constants, thus explaining that the tests FAIL there,
too.

FreeBSD 14.0 <sys/socket.h> is the same, so this seems to be a common theme.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
I think I've found what's going on: <sys/socket.h> really has

#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
#ifndef NC_TPI_CLTS
#define NC_TPI_CLTS     1               /* must agree with netconfig.h */
#define NC_TPI_COTS     2               /* must agree with netconfig.h */
[...]
#if !defined(_XPG4_2) || defined(__EXTENSIONS__)
#define SOCK_STREAM     NC_TPI_COTS     /* stream socket */
#define SOCK_DGRAM      NC_TPI_CLTS     /* datagram socket */
[...]
#else
#define SOCK_STREAM     2               /* stream socket */
#define SOCK_DGRAM      1               /* datagram socket */

The problem seems to be the indirection: when SOCK_DGRAM etc. are
defined as numeric constants, things work, while the indirection via
NC_TPI_* does not.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
When I hack <sys/socket.h> locally to avoid the indirection in the
definitions of the SOCK_* constants, only two gcc.dg/analyzer/fd-*.c
tests FAIL on Solaris:

FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
19)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
27)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
32)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
39)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c  (test for warnings, line
55)
FAIL: gcc.dg/analyzer/fd-access-mode-target-headers.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c:55:3:
warning: named constant 'O_ACCMODE' has unknown value

<sys/fcntl.h> (included from <fcntl.h>) has

#define O_ACCMODE       (O_SEARCH | O_EXEC | 0x3)

which analyzer cannot handle (not a simple numeric constant; same issue
as with SOCK_*).

Linux/glibc has instead

#define O_ACCMODE       00000003

FAIL: gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c (test for excess
errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:91:3:
error: implicit declaration of function 'memset'
[-Wimplicit-function-declaration]

Solaris <sys/select.h> has

#define FD_ZERO(__p)    (void) memset((__p), 0, sizeof (*(__p))) 

While one certainly could argue that the header should be
self-contained, it's easy enough to just include <string.h> in the test
to avoid this.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:f97d86f897bcf0ffda4d8d2e5b78a160e9ece140

commit r15-486-gf97d86f897bcf0ffda4d8d2e5b78a160e9ece140
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Tue May 14 16:23:14 2024 +0200

    testsuite: analyzer: Fix fd-glibc-byte-stream-connection-server.c on
Solaris [PR107750]

    gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c currently FAILs
    on Solaris:

    FAIL: gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c (test for
    excess errors)

    Excess errors:
   
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:91:3:
    error: implicit declaration of function 'memset'
    [-Wimplicit-function-declaration]

    Solaris <sys/select.h> has

    but no declaration of memset.  While one can argue that this should be
    fixed, it's easy enough to just include <string.h> instead, which is
    what this patch does.

    Tested on i386-pc-solaris2.11 and i686-pc-linux-gnu.

    2024-05-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR analyzer/107750
            * gcc.dg/analyzer/fd-glibc-byte-stream-connection-server.c:
            Include <string.h>.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.3                        |13.4

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 13.3 is being released, retargeting bugs to GCC 13.4.

[Bug analyzer/107750] [13/14/15 Regression] Many gcc.dg/analyzer/fd-*.c tests FAIL

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107750

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:09ae36461ed34f343f2d8299bad7e394cccf996e

commit r15-1004-g09ae36461ed34f343f2d8299bad7e394cccf996e
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Tue Jun 4 09:04:25 2024 +0200

    testsuite: analyzer: Skip tests with non-numeric macros on Solaris
[PR107750]

    A couple of gcc.dg/analyzer/fd-*.c tests still FAIL on Solaris.  The
    reason is always the same: they use macros that don't expand to simple
    numbers, something which c/c-parser.cc
    (ana::c_translation_unit::consider_macro) cannot handle:

    * <sys/socket.h>:

    * <sys/fcntl.h>:

    To avoid the resulting noise, this patch skips the affected tests.

    Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, and
    x86_64-pc-linux-gnu.

    2024-06-03  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR analyzer/107750
            * gcc.dg/analyzer/fd-accept.c: Skip on *-*-solaris2*.
            * gcc.dg/analyzer/fd-access-mode-target-headers.c: Likewise.
            * gcc.dg/analyzer/fd-connect.c: Likewise.
            * gcc.dg/analyzer/fd-datagram-socket.c: Likewise.
            * gcc.dg/analyzer/fd-listen.c: Likewise.
            * gcc.dg/analyzer/fd-socket-misuse.c: Likewise.
            * gcc.dg/analyzer/fd-stream-socket-active-open.c: Likewise.
            * gcc.dg/analyzer/fd-stream-socket-passive-open.c: Likewise.
            * gcc.dg/analyzer/fd-stream-socket.c: Likewise.