[Bug c++/107781] New: strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[Bug c++/107781] New: strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

            Bug ID: 107781
           Summary: strchrnul' was not declared in this scope; did you
                    mean 'strchr'? For contracts for canadian compilation
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

I do canadian compilation and it fails due to contracts.cc

../../../../../gcc/gcc/cp/contracts.cc: In function 'bool role_name_equal(const
char*, const char*)':
../../../../../gcc/gcc/cp/contracts.cc:213:21: error: 'strchrnul' was not
declared in this scope; did you mean 'strchr'?
  213 |   size_t role_len = strchrnul (role, ':') - role;
      |                     ^~~~~~~~~
      |                     strchr

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
*** Bug 107780 has been marked as a duplicate of this bug. ***

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-11-21
     Ever confirmed|0                           |1
           Keywords|                            |build
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
https://gcc.gnu.org/pipermail/gcc/2022-November/240070.html

Fails for macOS too. Probably others, as strchrnul is glibc-specific.

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at gcc dot gnu.org

--- Comment #3 from David Edelsohn <dje at gcc dot gnu.org> ---
AIX as well.

Although, apparently strchrnul() is provided a z/OS extension, so, hey, you can
build it there too! :-P.

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
If we don't want to introduce a configure check for strchrnul then this would
work:

--- a/gcc/cp/contracts.cc
+++ b/gcc/cp/contracts.cc
@@ -210,8 +210,8 @@ lookup_concrete_semantic (const char *name)
 static bool
 role_name_equal (const char *role, const char *name)
 {
-  size_t role_len = strchrnul (role, ':') - role;
-  size_t name_len = strchrnul (name, ':') - name;
+  size_t role_len = strcspn (role, ":");
+  size_t name_len = strcspn (name, ":");
   if (role_len != name_len)
     return false;
   return strncmp (role, name, role_len) == 0;

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606940.html

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #4)
> If we don't want to introduce a configure check for strchrnul then this
> would work:
> 
> --- a/gcc/cp/contracts.cc
> +++ b/gcc/cp/contracts.cc
> @@ -210,8 +210,8 @@ lookup_concrete_semantic (const char *name)
>  static bool
>  role_name_equal (const char *role, const char *name)
>  {
> -  size_t role_len = strchrnul (role, ':') - role;
> -  size_t name_len = strchrnul (name, ':') - name;
> +  size_t role_len = strcspn (role, ":");
> +  size_t name_len = strcspn (name, ":");
>    if (role_len != name_len)
>      return false;
>    return strncmp (role, name, role_len) == 0;

Yes, though I bet strcspn is often slower, because it has to support many
reject characters, not just 2 (the one specified plus '\0').
Though, on glibc it won't be much slower, due to:
  if (__glibc_unlikely (reject[0] == '\0')
      || __glibc_unlikely (reject[1] == '\0'))
    return __strchrnul (str, reject [0]) - str;
done at the start of strcspn.

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:ac5054144bd2248e948842937448eb5f4ce36bfd

commit r13-4236-gac5054144bd2248e948842937448eb5f4ce36bfd
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Nov 21 17:42:14 2022 -0500

    c++: don't use strchrnul [PR107781]

    The contracts implementation was using strchrnul, which is a glibc
    extension, so bootstrap broke on non-glibc targets.  Use C89 strcspn
    instead.

            PR c++/107781

    gcc/cp/ChangeLog:

            * contracts.cc (role_name_equal): Use strcspn instead
            of strchrnul.

[Bug c++/107781] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed.

[Bug c++/107781] [13 Regression] strchrnul' was not declared in this scope; did you mean 'strchr'? For contracts for canadian compilation

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107781

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
            Summary|strchrnul' was not declared |[13 Regression] strchrnul'
                   |in this scope; did you mean |was not declared in this
                   |'strchr'? For contracts for |scope; did you mean
                   |canadian compilation        |'strchr'? For contracts for
                   |                            |canadian compilation