[Bug analyzer/107807] New: gcc.dg/analyzer/errno-1.c FAILs

[Bug analyzer/107807] New: gcc.dg/analyzer/errno-1.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

            Bug ID: 107807
           Summary: gcc.dg/analyzer/errno-1.c FAILs
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11, x86_64-unknown-freebsd12.4,
                    hppa64-hp-hpux11.11

Since 20221108 (i.e. since it was committed), gcc.dg/analyzer/errno-1.c FAILs
on several targets.  I see it on 32 and 64-bit Solaris/SPARC and x86:

+FAIL: gcc.dg/analyzer/errno-1.c  (test for warnings, line 22)
+FAIL: gcc.dg/analyzer/errno-1.c (test for excess errors)

Excess errors:
/vol/gcc/src/hg/master/local/gcc/testsuite/gcc.dg/analyzer/errno-1.c:22:3:
warning: TRUE

and there are other reports on gcc-testresults as well.

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this bug; sorry about the test failures.

I've tested errno-1.c with glibc's errno.h, and with a simple "extern int
errno;".

What does <errno.h> look like on your machine?  In particular, how is "errno"
defined/declared?  Thanks.

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---

> I've tested errno-1.c with glibc's errno.h, and with a simple "extern int
> errno;".
>
> What does <errno.h> look like on your machine?  In particular, how is "errno"
> defined/declared?  Thanks.

It's a bit more complicated here, boiling down to

extern int *___errno(void) __attribute__((__const__));
#define errno (*(___errno()))

You will find something similar e.g. on Mac OS X 10.7, btw.:

extern int * __error(void);
#define errno (*__error())

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2022-11-22

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks; am working on a fix.

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:7c9717fcb5cf94ce1e7ef5c903058adf9980ff28

commit r13-4247-g7c9717fcb5cf94ce1e7ef5c903058adf9980ff28
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Tue Nov 22 17:29:21 2022 -0500

    analyzer: fix 'errno' on Solaris and OS X [PR107807]

    gcc/analyzer/ChangeLog:
            PR analyzer/107807
            * region-model-impl-calls.cc (register_known_functions): Register
            "___errno" and "__error" as synonyms  for "__errno_location".

    gcc/testsuite/ChangeLog:
            PR analyzer/107807
            * gcc.dg/analyzer/errno-___errno.c: New test.
            * gcc.dg/analyzer/errno-__error.c: New test.
            * gcc.dg/analyzer/errno-global-var.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Did the above patch fix things?

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
It did in last night's Solaris bootstraps (sparc and x86).  macOS bootstraps
are
super-slow, so I'll wait for tomorrow night's weekly bootstraps there and
report
back when they are finished.

Thanks.

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
> It did in last night's Solaris bootstraps (sparc and x86).  macOS bootstraps
> are
> super-slow, so I'll wait for tomorrow night's weekly bootstraps there and
> report
> back when they are finished.

The Mac OS X 10.7 have finished now and as expected, the failures are gone.

[Bug analyzer/107807] gcc.dg/analyzer/errno-1.c FAILs

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107807

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks; marking this as resolved.